Second patch in making destructors of refcounted objects private.

net/url_request/url_request_ftp_job.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_URL_REQUEST_URL_REQUEST_FTP_JOB_H_
 #define NET_URL_REQUEST_URL_REQUEST_FTP_JOB_H_
 
 #include <string>
 
 #include "net/url_request/url_request_inet_job.h"
 
 // A basic FTP job that handles download files and showing directory listings.
 class URLRequestFtpJob : public URLRequestInetJob {
  public:
   static URLRequestJob* Factory(URLRequest* request, const std::string& scheme);
 
-  virtual ~URLRequestFtpJob();
-
   // URLRequestJob methods:
   virtual void Start();
   virtual bool GetMimeType(std::string* mime_type) const;
 
   // URLRequestInetJob methods:
   virtual void OnIOComplete(const AsyncResult& result);
 
  protected:
   explicit URLRequestFtpJob(URLRequest* request);
 
   // Starts the WinInet request.
   virtual void SendRequest();
 
   virtual int CallInternetRead(char* dest, int dest_size, int *bytes_read);
   virtual bool GetReadBytes(const AsyncResult& result, int* bytes_read);
   virtual void OnCancelAuth();
   virtual void OnSetAuth();
   virtual bool NeedsAuth();
   virtual void GetAuthChallengeInfo(scoped_refptr<net::AuthChallengeInfo>*);
   virtual bool IsRedirectResponse(GURL* location, int* http_status_code);
 
  private:
+  ~URLRequestFtpJob();

[eroman, 2009/11/05 20:52:19]

was it intentional to remove the virtual keyword?
(shouldn't matter, just curious).

[jam, 2009/11/05 21:56:02]

it wasn't needed, but I'll keep it the way it was and put it back

+
   // Called after InternetConnect successfully connects to server.
   void OnConnect();
 
   // Called after FtpSetCurrentDirectory attempts to change current dir.
   void OnSetCurrentDirectory(DWORD last_error);
 
   // Requests the next file in the directory listing from WinInet.
   void FindNextFile();
 
   // Called when the first file in a directory listing is available.
@@ skipping 56 matching lines @@
   // buffer in between the time a Read() call comes in and we get the file
   // entry from WinInet.
   char* dest_;
   int dest_size_;
 
 
   DISALLOW_EVIL_CONSTRUCTORS(URLRequestFtpJob);
 };
 
 #endif  // NET_URL_REQUEST_URL_REQUEST_FTP_JOB_H_