Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Unified Diff: net/socket/tcp_client_socket_win.cc

Issue 368001: Second patch in making destructors of refcounted objects private. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/tcp_client_socket_win.cc
===================================================================
--- net/socket/tcp_client_socket_win.cc (revision 31079)
+++ net/socket/tcp_client_socket_win.cc (working copy)
@@ -126,7 +126,6 @@
class TCPClientSocketWin::Core : public base::RefCounted<Core> {
public:
explicit Core(TCPClientSocketWin* socket);
- ~Core();
// Start watching for the end of a read or write operation.
void WatchForRead();
@@ -161,6 +160,10 @@
}
private:
+ friend class base::RefCounted<Core>;
+
+ ~Core();
eroman 2009/11/05 20:52:19 nit: move this after the inner class definitions.
jam 2009/11/05 21:56:02 Done.
+
class ReadDelegate : public base::ObjectWatcher::Delegate {
public:
explicit ReadDelegate(Core* core) : core_(core) {}

Powered by Google App Engine
This is Rietveld 408576698