Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 270062: Use ASCII strings for switch names. (Closed)

Created:
11 years, 2 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
tony, agl
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Use ASCII strings for switch names. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28779

Patch Set 1 #

Patch Set 2 : victory #

Unified diffs Side-by-side diffs Delta from patch set Stats (+680 lines, -653 lines) Patch
M app/app_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M app/app_switches.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/base_switches.h View 1 chunk +8 lines, -8 lines 0 comments Download
M base/base_switches.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M base/command_line.h View 1 3 chunks +24 lines, -6 lines 0 comments Download
M base/command_line.cc View 1 6 chunks +26 lines, -28 lines 0 comments Download
M base/command_line_unittest.cc View 2 chunks +25 lines, -25 lines 0 comments Download
M base/debug_on_start.h View 1 chunk +1 line, -1 line 0 comments Download
M base/debug_on_start.cc View 1 chunk +5 lines, -1 line 0 comments Download
M base/multiprocess_test.h View 1 chunk +1 line, -1 line 0 comments Download
M base/test/perf_test_suite.h View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_suite.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/chrome_dll_main.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/first_run_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/gtk/browser_titlebar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/firefox_importer_unittest_utils_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/locale_tests_uitest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/nacl_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_url_request_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/printing_layout_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/process_singleton_linux_uitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profile.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sandbox_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_plugin_util.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +177 lines, -177 lines 0 comments Download
M chrome/common/chrome_switches.cc View 4 chunks +164 lines, -165 lines 0 comments Download
M chrome/common/debug_flags.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/common/logging_chrome.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/sandbox_init_wrapper.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/sandbox_init_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_chrome_distribution.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/installer/util/logging_installer.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M chrome/installer/util/shell_util.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/test/automated_ui_tests/automated_ui_tests.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/test/mini_installer_test/run_all_unittests.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/reliability/page_load_test.cc View 2 chunks +15 lines, -15 lines 0 comments Download
M chrome/test/test_launcher/out_of_proc_test_runner.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/test_launcher/test_runner.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/test/ui/dom_checker_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ui/omnibox_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ui/sunspider_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ui/ui_test.cc View 1 3 chunks +12 lines, -12 lines 0 comments Download
M chrome/test/ui/ui_test_suite.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/ui/ui_test_suite.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/ui/v8_benchmark_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/url_fetch_test/url_fetch_test.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/tools/crash_service/crash_service.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/tools/crash_service/crash_service.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome_frame/chrome_launcher_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M courgette/courgette_tool.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M ipc/ipc_switches.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ipc/ipc_switches.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M media/bench/bench.cc View 2 chunks +13 lines, -13 lines 0 comments Download
M net/tools/dump_cache/dump_cache.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/fetch/fetch_client.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M net/tools/fetch/fetch_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M o3d/converter/cross/converter_main.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M o3d/converter/cross/verifier_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M o3d/converter_edge/cross/converter_main.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M o3d/converter_edge/cross/verifier_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/imagediff/image_diff.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/plugins/plugin_constants_win.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/plugin_list_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webworkerclient_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/node_leak_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_switches.h View 1 chunk +24 lines, -24 lines 0 comments Download
M webkit/tools/test_shell/test_shell_switches.cc View 1 chunk +25 lines, -25 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Martin
PATCH OF DOOM
11 years, 2 months ago (2009-10-11 16:51:48 UTC) #1
Evan Martin
hold off on this review, forgot i need to get windows working first
11 years, 2 months ago (2009-10-11 16:57:49 UTC) #2
Evan Martin
ok, now passes trybots
11 years, 2 months ago (2009-10-12 05:00:09 UTC) #3
agl
LGTM
11 years, 2 months ago (2009-10-12 16:14:45 UTC) #4
tony
11 years, 2 months ago (2009-10-12 17:00:56 UTC) #5 
Rubber stamp LG

Powered by Google App Engine
This is Rietveld 408576698