Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Side by Side Diff: chrome/browser/nacl_process_host.cc

Issue 270062: Use ASCII strings for switch names. (Closed)
Patch Set: victory Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/locale_tests_uitest.cc ('k') | chrome/browser/net/chrome_url_request_context.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "build/build_config.h" 5 #include "build/build_config.h"
6 6
7 #include "chrome/browser/nacl_process_host.h" 7 #include "chrome/browser/nacl_process_host.h"
8 8
9 #if defined(OS_POSIX) 9 #if defined(OS_POSIX)
10 #include <fcntl.h> 10 #include <fcntl.h>
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 if (exe_path.empty() && !PathService::Get(base::FILE_EXE, &exe_path)) 100 if (exe_path.empty() && !PathService::Get(base::FILE_EXE, &exe_path))
101 return false; 101 return false;
102 102
103 CommandLine cmd_line(exe_path); 103 CommandLine cmd_line(exe_path);
104 if (logging::DialogsAreSuppressed()) 104 if (logging::DialogsAreSuppressed())
105 cmd_line.AppendSwitch(switches::kNoErrorDialogs); 105 cmd_line.AppendSwitch(switches::kNoErrorDialogs);
106 106
107 // propagate the following switches to the plugin command line (along with 107 // propagate the following switches to the plugin command line (along with
108 // any associated values) if present in the browser command line 108 // any associated values) if present in the browser command line
109 // TODO(gregoryd): check which flags of those below can be supported. 109 // TODO(gregoryd): check which flags of those below can be supported.
110 static const wchar_t* const switch_names[] = { 110 static const char* const switch_names[] = {
111 switches::kNoSandbox, 111 switches::kNoSandbox,
112 switches::kTestSandbox, 112 switches::kTestSandbox,
113 switches::kDisableBreakpad, 113 switches::kDisableBreakpad,
114 switches::kFullMemoryCrashReport, 114 switches::kFullMemoryCrashReport,
115 switches::kEnableLogging, 115 switches::kEnableLogging,
116 switches::kDisableLogging, 116 switches::kDisableLogging,
117 switches::kLoggingLevel, 117 switches::kLoggingLevel,
118 switches::kEnableDCHECK, 118 switches::kEnableDCHECK,
119 switches::kSilentDumpOnDCHECK, 119 switches::kSilentDumpOnDCHECK,
120 switches::kMemoryProfiling, 120 switches::kMemoryProfiling,
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 182
183 void NaClProcessHost::OnMessageReceived(const IPC::Message& msg) { 183 void NaClProcessHost::OnMessageReceived(const IPC::Message& msg) {
184 NOTREACHED() << "Invalid message with type = " << msg.type(); 184 NOTREACHED() << "Invalid message with type = " << msg.type();
185 } 185 }
186 186
187 URLRequestContext* NaClProcessHost::GetRequestContext( 187 URLRequestContext* NaClProcessHost::GetRequestContext(
188 uint32 request_id, 188 uint32 request_id,
189 const ViewHostMsg_Resource_Request& request_data) { 189 const ViewHostMsg_Resource_Request& request_data) {
190 return NULL; 190 return NULL;
191 } 191 }
OLDNEW
« no previous file with comments | « chrome/browser/locale_tests_uitest.cc ('k') | chrome/browser/net/chrome_url_request_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698