Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3198)

Unified Diff: chrome_frame/chrome_launcher_unittest.cc

Issue 270062: Use ASCII strings for switch names. (Closed)
Patch Set: victory Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/tools/crash_service/crash_service.cc ('k') | courgette/courgette_tool.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/chrome_launcher_unittest.cc
diff --git a/chrome_frame/chrome_launcher_unittest.cc b/chrome_frame/chrome_launcher_unittest.cc
index 1181f0963034a3ab4a085d50bdf94ea0ebfd0c24..268369dcc1d866708fbf9e78491e783905a89e6e 100644
--- a/chrome_frame/chrome_launcher_unittest.cc
+++ b/chrome_frame/chrome_launcher_unittest.cc
@@ -33,7 +33,7 @@ TEST(ChromeLauncher, SanitizeCommandLine) {
CommandLine bad(L"dummy.exe");
bad.AppendSwitch(switches::kDisableMetrics); // in whitelist
bad.AppendSwitchWithValue(switches::kLoadExtension, L"foo"); // in whitelist
- bad.AppendSwitch(L"no-such-switch"); // does not exist
+ bad.AppendSwitch("no-such-switch"); // does not exist
bad.AppendSwitch(switches::kHomePage); // exists but not in whitelist
LogDisabler no_dchecks;
@@ -42,7 +42,7 @@ TEST(ChromeLauncher, SanitizeCommandLine) {
chrome_launcher::SanitizeCommandLine(bad, &sanitized);
EXPECT_TRUE(sanitized.HasSwitch(switches::kDisableMetrics));
EXPECT_TRUE(sanitized.HasSwitch(switches::kLoadExtension));
- EXPECT_FALSE(sanitized.HasSwitch(L"no-such-switch"));
+ EXPECT_FALSE(sanitized.HasSwitch("no-such-switch"));
EXPECT_FALSE(sanitized.HasSwitch(switches::kHomePage));
EXPECT_EQ(sanitized.GetSwitchValue(switches::kLoadExtension), L"foo");
« no previous file with comments | « chrome/tools/crash_service/crash_service.cc ('k') | courgette/courgette_tool.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698