Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1715)

Unified Diff: chrome/installer/util/shell_util.cc

Issue 270062: Use ASCII strings for switch names. (Closed)
Patch Set: victory Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/logging_installer.cc ('k') | chrome/test/automated_ui_tests/automated_ui_tests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/shell_util.cc
diff --git a/chrome/installer/util/shell_util.cc b/chrome/installer/util/shell_util.cc
index c4705a86166d615e6ad487b567f907b9fa01606a..d00e2623239d44dab6bece5de669cba054319f08 100644
--- a/chrome/installer/util/shell_util.cc
+++ b/chrome/installer/util/shell_util.cc
@@ -81,12 +81,13 @@ class RegistryEntry {
start_menu_entry + ShellUtil::kRegDefaultIcon, icon_path));
std::wstring install_info(start_menu_entry + L"\\InstallInfo");
+ // TODO: use CommandLine API instead of constructing command lines.
entries->push_front(new RegistryEntry(install_info, L"ReinstallCommand",
- quoted_exe_path + L" --" + switches::kMakeDefaultBrowser));
+ quoted_exe_path + L" --" + ASCIIToWide(switches::kMakeDefaultBrowser)));
entries->push_front(new RegistryEntry(install_info, L"HideIconsCommand",
- quoted_exe_path + L" --" + switches::kHideIcons));
+ quoted_exe_path + L" --" + ASCIIToWide(switches::kHideIcons)));
entries->push_front(new RegistryEntry(install_info, L"ShowIconsCommand",
- quoted_exe_path + L" --" + switches::kShowIcons));
+ quoted_exe_path + L" --" + ASCIIToWide(switches::kShowIcons)));
entries->push_front(new RegistryEntry(install_info, L"IconsVisible", 1));
std::wstring capabilities(start_menu_entry + L"\\Capabilities");
« no previous file with comments | « chrome/installer/util/logging_installer.cc ('k') | chrome/test/automated_ui_tests/automated_ui_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698