Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: chrome/test/test_launcher/out_of_proc_test_runner.cc

Issue 270062: Use ASCII strings for switch names. (Closed)
Patch Set: victory Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/reliability/page_load_test.cc ('k') | chrome/test/test_launcher/test_runner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/test_launcher/out_of_proc_test_runner.cc
diff --git a/chrome/test/test_launcher/out_of_proc_test_runner.cc b/chrome/test/test_launcher/out_of_proc_test_runner.cc
index 3d02bcbc5d835352662e6dcf107dd4818d362887..dd1f5af0cb6d6f347248f2caa2a19ad5c5b673f3 100644
--- a/chrome/test/test_launcher/out_of_proc_test_runner.cc
+++ b/chrome/test/test_launcher/out_of_proc_test_runner.cc
@@ -15,8 +15,8 @@
namespace {
-const wchar_t* const kGTestListTestsFlag = L"gtest_list_tests";
-const wchar_t* const kChildProcessFlag = L"child";
+const char kGTestListTestsFlag[] = "gtest_list_tests";
+const char kChildProcessFlag[] = "child";
class OutOfProcTestRunner : public tests::TestRunner {
public:
@@ -36,8 +36,8 @@ class OutOfProcTestRunner : public tests::TestRunner {
CommandLine new_cmd_line(cmd_line->argv());
// Always enable disabled tests. This method is not called with disabled
// tests unless this flag was specified to the browser test executable.
- new_cmd_line.AppendSwitch(L"gtest_also_run_disabled_tests");
- new_cmd_line.AppendSwitchWithValue(L"gtest_filter", ASCIIToWide(test_name));
+ new_cmd_line.AppendSwitch("gtest_also_run_disabled_tests");
+ new_cmd_line.AppendSwitchWithValue("gtest_filter", test_name);
new_cmd_line.AppendSwitch(kChildProcessFlag);
base::ProcessHandle process_handle;
« no previous file with comments | « chrome/test/reliability/page_load_test.cc ('k') | chrome/test/test_launcher/test_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698