Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 269104: Mark some disabled tests as flaky to increase test coverage. (Closed)

Created:
11 years, 2 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Mark some disabled tests as flaky to increase test coverage. When a test doesn't hang or crash, it can run on the bots and on developers' machines. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29279

Patch Set 1 #

Total comments: 3

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M base/condition_variable_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/timer_unittest.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/session_history_uitest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/tab_restore_uitest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/views/find_bar_host_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/views/tabs/tab_dragging_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/automation_proxy_uitest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M net/disk_cache/backend_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
11 years, 2 months ago (2009-10-16 08:19:43 UTC) #1
Erik does not do reviews
http://codereview.chromium.org/269104/diff/1/3 File base/timer_unittest.cc (right): http://codereview.chromium.org/269104/diff/1/3#newcode321 Line 321: // It's flaky on the buildbot. Bug not ...
11 years, 2 months ago (2009-10-16 15:01:50 UTC) #2
Nicolas Sylvain
11 years, 2 months ago (2009-10-16 15:04:07 UTC) #3
I agree with erik's comments, lgtm otherwise. thanks

Powered by Google App Engine
This is Rietveld 408576698