Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: chrome/browser/session_history_uitest.cc

Issue 269104: Mark some disabled tests as flaky to increase test coverage. (Closed)
Patch Set: fixes Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/timer_unittest.cc ('k') | chrome/browser/tab_restore_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/session_history_uitest.cc
diff --git a/chrome/browser/session_history_uitest.cc b/chrome/browser/session_history_uitest.cc
index 3daab18f66eede309dbfc04a44d4b3fff0b95805..fe06d8b8ba10c2dd7cc4b4b55dd5135fd7979173 100644
--- a/chrome/browser/session_history_uitest.cc
+++ b/chrome/browser/session_history_uitest.cc
@@ -483,9 +483,9 @@ TEST_F(SessionHistoryTest, JavascriptHistory) {
// NotificationService.)
}
-// This test is flaky and has been disabled. It looks like the server does not
-// start fast enough, and the navigation fails (with 404). See bug 8444.
-TEST_F(SessionHistoryTest, DISABLED_LocationReplace) {
+// This test is flaky. It looks like the server does not start fast enough,
+// and the navigation fails (with 404). See http://crbug.com/8444.
+TEST_F(SessionHistoryTest, FLAKY_LocationReplace) {
// Test that using location.replace doesn't leave the title of the old page
// visible.
scoped_refptr<HTTPTestServer> server =
« no previous file with comments | « base/timer_unittest.cc ('k') | chrome/browser/tab_restore_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698