Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: net/disk_cache/backend_unittest.cc

Issue 269104: Mark some disabled tests as flaky to increase test coverage. (Closed)
Patch Set: fixes Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/automation/automation_proxy_uitest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/disk_cache/backend_unittest.cc
diff --git a/net/disk_cache/backend_unittest.cc b/net/disk_cache/backend_unittest.cc
index 5fc465342857c88104a1ca95dc5f6f936d5e4bd5..6609d3a949c0022520c9dd4b8bcd177c3276cbf9 100644
--- a/net/disk_cache/backend_unittest.cc
+++ b/net/disk_cache/backend_unittest.cc
@@ -1413,9 +1413,9 @@ TEST_F(DiskCacheBackendTest, DisableSuccess4) {
BackendDisable4();
}
-// Flaky, http://crbug.com/21110. Don't re-enable without a real fix or adding
-// more debugging info!
-TEST_F(DiskCacheBackendTest, DISABLED_NewEvictionDisableSuccess4) {
+// Flaky, http://crbug.com/21110.
+// TODO(rvargas): Add more debugging code to help identify the root cause.
+TEST_F(DiskCacheBackendTest, FLAKY_NewEvictionDisableSuccess4) {
ASSERT_TRUE(CopyTestCache(L"bad_rankings"));
DisableFirstCleanup();
SetDirectMode();
« no previous file with comments | « chrome/test/automation/automation_proxy_uitest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698