Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3274)

Unified Diff: chrome/browser/tab_restore_uitest.cc

Issue 269104: Mark some disabled tests as flaky to increase test coverage. (Closed)
Patch Set: fixes Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/session_history_uitest.cc ('k') | chrome/browser/views/find_bar_host_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_restore_uitest.cc
diff --git a/chrome/browser/tab_restore_uitest.cc b/chrome/browser/tab_restore_uitest.cc
index 70a4a39c52271f271d80c9ce8930110762b50d38..491ba8ac1366b31af550401aa00c430f8303f3dc 100644
--- a/chrome/browser/tab_restore_uitest.cc
+++ b/chrome/browser/tab_restore_uitest.cc
@@ -200,8 +200,8 @@ TEST_F(TabRestoreUITest, MiddleTab) {
// Close a tab, switch windows, then restore the tab. The tab should be in its
// original window and position, and active.
-// Disabled because flacky. See http://crbug.com/14132 and 11213.
-TEST_F(TabRestoreUITest, DISABLED_RestoreToDifferentWindow) {
+// This test is flaky. See http://crbug.com/14132 and 11213.
+TEST_F(TabRestoreUITest, FLAKY_RestoreToDifferentWindow) {
scoped_refptr<BrowserProxy> browser_proxy(automation()->GetBrowserWindow(0));
// This call is virtually guaranteed to pass, assuming that Chromium is the
@@ -336,8 +336,8 @@ TEST_F(TabRestoreUITest, DISABLED_DontLoadRestoredTab) {
// Open a window with multiple tabs, close a tab, then close the window.
// Restore both and make sure the tab goes back into the window.
-// Disabled because flakey. See http://crbug.com/14132
-TEST_F(TabRestoreUITest, DISABLED_RestoreWindowAndTab) {
+// This test is flaky. See http://crbug.com/14132
+TEST_F(TabRestoreUITest, FLAKY_RestoreWindowAndTab) {
scoped_refptr<BrowserProxy> browser_proxy(automation()->GetBrowserWindow(0));
CheckActiveWindow(browser_proxy.get());
« no previous file with comments | « chrome/browser/session_history_uitest.cc ('k') | chrome/browser/views/find_bar_host_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698