Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Side by Side Diff: chrome/test/automation/automation_proxy_uitest.cc

Issue 269104: Mark some disabled tests as flaky to increase test coverage. (Closed)
Patch Set: fixes Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/views/tabs/tab_dragging_test.cc ('k') | net/disk_cache/backend_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "app/app_switches.h" 7 #include "app/app_switches.h"
8 #include "app/l10n_util.h" 8 #include "app/l10n_util.h"
9 #include "app/message_box_flags.h" 9 #include "app/message_box_flags.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 1053 matching lines...) Expand 10 before | Expand all | Expand 10 after
1064 EXPECT_TRUE(edit->SetText(L"Roflcopter")); 1064 EXPECT_TRUE(edit->SetText(L"Roflcopter"));
1065 EXPECT_TRUE(edit->WaitForQuery(30000)); 1065 EXPECT_TRUE(edit->WaitForQuery(30000));
1066 bool query_in_progress; 1066 bool query_in_progress;
1067 EXPECT_TRUE(edit->IsQueryInProgress(&query_in_progress)); 1067 EXPECT_TRUE(edit->IsQueryInProgress(&query_in_progress));
1068 EXPECT_FALSE(query_in_progress); 1068 EXPECT_FALSE(query_in_progress);
1069 std::vector<AutocompleteMatchData> matches; 1069 std::vector<AutocompleteMatchData> matches;
1070 EXPECT_TRUE(edit->GetAutocompleteMatches(&matches)); 1070 EXPECT_TRUE(edit->GetAutocompleteMatches(&matches));
1071 EXPECT_FALSE(matches.empty()); 1071 EXPECT_FALSE(matches.empty());
1072 } 1072 }
1073 1073
1074 // Disabled because flaky see bug #5314. 1074 // This test is flaky, see http://crbug.com/5314. Disabled because it hangs
1075 // on Mac (http://crbug.com/25039).
1075 TEST_F(AutomationProxyTest, DISABLED_AppModalDialogTest) { 1076 TEST_F(AutomationProxyTest, DISABLED_AppModalDialogTest) {
1076 scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0)); 1077 scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
1077 ASSERT_TRUE(browser.get()); 1078 ASSERT_TRUE(browser.get());
1078 scoped_refptr<TabProxy> tab(browser->GetTab(0)); 1079 scoped_refptr<TabProxy> tab(browser->GetTab(0));
1079 ASSERT_TRUE(tab.get()); 1080 ASSERT_TRUE(tab.get());
1080 1081
1081 bool modal_dialog_showing = false; 1082 bool modal_dialog_showing = false;
1082 MessageBoxFlags::DialogButton button = MessageBoxFlags::DIALOGBUTTON_NONE; 1083 MessageBoxFlags::DialogButton button = MessageBoxFlags::DIALOGBUTTON_NONE;
1083 EXPECT_TRUE(automation()->GetShowingAppModalDialog(&modal_dialog_showing, 1084 EXPECT_TRUE(automation()->GetShowingAppModalDialog(&modal_dialog_showing,
1084 &button)); 1085 &button));
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
1181 1182
1182 // Allow some time for the popup to show up and close. 1183 // Allow some time for the popup to show up and close.
1183 PlatformThread::Sleep(2000); 1184 PlatformThread::Sleep(2000);
1184 1185
1185 std::wstring expected(L"string"); 1186 std::wstring expected(L"string");
1186 std::wstring jscript = CreateJSString(L"\"" + expected + L"\""); 1187 std::wstring jscript = CreateJSString(L"\"" + expected + L"\"");
1187 std::wstring actual; 1188 std::wstring actual;
1188 ASSERT_TRUE(tab->ExecuteAndExtractString(L"", jscript, &actual)); 1189 ASSERT_TRUE(tab->ExecuteAndExtractString(L"", jscript, &actual));
1189 ASSERT_EQ(expected, actual); 1190 ASSERT_EQ(expected, actual);
1190 } 1191 }
OLDNEW
« no previous file with comments | « chrome/browser/views/tabs/tab_dragging_test.cc ('k') | net/disk_cache/backend_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698