Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2607)

Unified Diff: base/timer_unittest.cc

Issue 269104: Mark some disabled tests as flaky to increase test coverage. (Closed)
Patch Set: fixes Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/condition_variable_unittest.cc ('k') | chrome/browser/session_history_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/timer_unittest.cc
diff --git a/base/timer_unittest.cc b/base/timer_unittest.cc
index 74c6a6630742891fd9979faab9c3c8fe4db2dfab..8c18947b9b130910cf5d461e85d99214ebdd9e7c 100644
--- a/base/timer_unittest.cc
+++ b/base/timer_unittest.cc
@@ -318,9 +318,8 @@ TEST(TimerTest, DelayTimer_OneCall) {
RunTest_DelayTimer_OneCall(MessageLoop::TYPE_IO);
}
-// Disabled because it's flaky on the buildbot. Bug not filed because this
-// kind of test is difficult to make not-flaky on buildbots.
-TEST(TimerTest, DISABLED_DelayTimer_Reset) {
+// It's flaky on the buildbot, http://crbug.com/25038.
+TEST(TimerTest, FLAKY_DelayTimer_Reset) {
RunTest_DelayTimer_Reset(MessageLoop::TYPE_DEFAULT);
RunTest_DelayTimer_Reset(MessageLoop::TYPE_UI);
RunTest_DelayTimer_Reset(MessageLoop::TYPE_IO);
« no previous file with comments | « base/condition_variable_unittest.cc ('k') | chrome/browser/session_history_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698