Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2689006: Refactor validation code so it can be modified at runtime.... (Closed)

Created:
10 years, 6 months ago by greggman
Modified:
9 years, 7 months ago
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Refactor validation code so it can be modified at runtime. I'll move the DXT stuff out after this CL lands. TEST=ran unit and conformance tests BUG=44368 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49850

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+743 lines, -761 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 3 4 5 chunks +74 lines, -15 lines 0 comments Download
M gpu/command_buffer/service/context_group.h View 1 2 3 4 3 chunks +7 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gl_utils.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 4 15 chunks +32 lines, -29 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 1 2 3 4 64 chunks +95 lines, -95 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation.h View 1 2 3 4 1 chunk +28 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation.cc View 1 2 3 4 1 chunk +4 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_autogen.h View 1 2 3 4 1 chunk +43 lines, -43 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 1 2 3 4 1 chunk +459 lines, -572 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
greggman
10 years, 6 months ago (2010-06-07 20:03:32 UTC) #1
greggman
ping. You originally wanted me to wait for your big change. That's in now. This ...
10 years, 6 months ago (2010-06-14 21:33:20 UTC) #2
apatrick
10 years, 6 months ago (2010-06-14 21:42:40 UTC) #3
Thanks for holding off. LGTM.

Powered by Google App Engine
This is Rietveld 408576698