Make mojom-generated C++ string constants really constant.

Make mojom-generated C++ string constants really constant.

Previously, string constants generated from mojoms were of the form
const char* kName = "value";
This allows kName to be changed at runtime to point at other strings.
This replaces those with
const char kName[] = "value";

This also changes mojom-generated scalar constants to be constexpr.

BUG=682102
Review-Url: https://codereview.chromium.org/2637393002
Cr-Commit-Position: refs/heads/master@{#444871}
Committed: https://chromium.googlesource.com/chromium/src/+/1bcfeb4b504a90db6bd008c4e87e895f5957161f

[Sam McNally, 2017-01-18 07:01:29]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 07:01:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2017-01-18 07:07:48]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 07:08:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 07:47:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 07:47:38]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Sam McNally, 2017-01-18 23:47:46]

Description was changed from

==========
Use constexpr for mojom-generated C++ constants.

Previously, string constants generated from mojom files used a
const char* kName = "value";
structure. This allows kName to be changed at runtime to point at other
strings. This changes C++ constants generated from mojom constants to
use constexpr and for strings to use the more standard form:
constexpr char kName[] = "value";

BUG=682102
==========

to

==========
Use a correct form for mojom-generated C++ string constants.

Previously, string constants generated from mojom files used a
const char* kName = "value";
structure. This allows kName to be changed at runtime to point at other
strings. This changes C++ constants generated from mojom constants to
use constexpr and for strings to use the more standard form:
const char kName[] = "value";

This also changes scalar constants to be constexpr.

BUG=682102
==========

[Sam McNally, 2017-01-18 23:54:42]

Description was changed from

==========
Use a correct form for mojom-generated C++ string constants.

Previously, string constants generated from mojom files used a
const char* kName = "value";
structure. This allows kName to be changed at runtime to point at other
strings. This changes C++ constants generated from mojom constants to
use constexpr and for strings to use the more standard form:
const char kName[] = "value";

This also changes scalar constants to be constexpr.

BUG=682102
==========

to

==========
Use a correct form for mojom-generated C++ string constants.

Previously, string constants generated from mojom files used a
const char* kName = "value";
structure. This allows kName to be changed at runtime to point at other
strings. This changes C++ constants generated from mojom constants to
use constexpr and for strings to use the more standard form:
const char kName[] = "value";

This also changes scalar constants to be constexpr.

BUG=682102
==========

[Sam McNally, 2017-01-18 23:54:51]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 23:55:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 02:14:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 02:14:15]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2017-01-19 05:47:59]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 05:48:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2017-01-19 05:58:34]

Description was changed from

==========
Use a correct form for mojom-generated C++ string constants.

Previously, string constants generated from mojom files used a
const char* kName = "value";
structure. This allows kName to be changed at runtime to point at other
strings. This changes C++ constants generated from mojom constants to
use constexpr and for strings to use the more standard form:
const char kName[] = "value";

This also changes scalar constants to be constexpr.

BUG=682102
==========

to

==========
Make mojom-generated C++ string constants really constant.

Previously, string constants generated from mojoms were of the form
const char* kName = "value";
This allows kName to be changed at runtime to point at other strings.
This replaces those with
const char kName[] = "value";

This also changes mojom-generated scalar constants to be constexpr.

BUG=682102
==========

[Sam McNally, 2017-01-19 06:10:45]

Description was changed from

==========
Make mojom-generated C++ string constants really constant.

Previously, string constants generated from mojoms were of the form
const char* kName = "value";
This allows kName to be changed at runtime to point at other strings.
This replaces those with
const char kName[] = "value";

This also changes mojom-generated scalar constants to be constexpr.

BUG=682102
==========

to

==========
Make mojom-generated C++ string constants really constant.

Previously, string constants generated from mojoms were of the form
const char* kName = "value";
This allows kName to be changed at runtime to point at other strings.
This replaces those with
const char kName[] = "value";

This also changes mojom-generated scalar constants to be constexpr.

BUG=682102
==========

[Sam McNally, 2017-01-19 06:26:52]

sammc@chromium.org changed reviewers:
+ yzshen@chromium.org

[commit-bot: I haz the power, 2017-01-19 07:59:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 07:59:22]

Dry run: This issue passed the CQ dry run.

[yzshen1, 2017-01-19 21:03:24]

LGTM

[Sam McNally, 2017-01-19 22:40:47]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2017-01-19 22:41:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 22:53:21]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484865647668940,
"parent_rev": "02e9bb3d16ab71e98fe162d7295eae3e67e102bd", "commit_rev":
"1bcfeb4b504a90db6bd008c4e87e895f5957161f"}

[commit-bot: I haz the power, 2017-01-19 22:53:53]

Description was changed from

==========
Make mojom-generated C++ string constants really constant.

Previously, string constants generated from mojoms were of the form
const char* kName = "value";
This allows kName to be changed at runtime to point at other strings.
This replaces those with
const char kName[] = "value";

This also changes mojom-generated scalar constants to be constexpr.

BUG=682102
==========

to

==========
Make mojom-generated C++ string constants really constant.

Previously, string constants generated from mojoms were of the form
const char* kName = "value";
This allows kName to be changed at runtime to point at other strings.
This replaces those with
const char kName[] = "value";

This also changes mojom-generated scalar constants to be constexpr.

BUG=682102

Review-Url: https://codereview.chromium.org/2637393002
Cr-Commit-Position: refs/heads/master@{#444871}
Committed:
https://chromium.googlesource.com/chromium/src/+/1bcfeb4b504a90db6bd008c4e87e...
==========

[commit-bot: I haz the power, 2017-01-19 22:53:54]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/1bcfeb4b504a90db6bd008c4e87e...