mojo/public/tools/bindings/generators/cpp_templates/enum_macros.tmpl - Issue 2637393002: Make mojom-generated C++ string constants really constant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/enum_macros.tmpl

Issue 2637393002: Make mojom-generated C++ string constants really constant. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/interfaces/bindings/tests/test_constants.mojom ('k') | mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/enum_macros.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/enum_macros.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/enum_macros.tmpl

index 087f225517db74e4772c5338adf30c56bfad60e0..9400ca77041e65cf319e0512101d619d4b63ecb6 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/enum_macros.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/enum_macros.tmpl

@@ -45,7 +45,7 @@ inline bool IsKnownEnumValue({{enum_name}} value) {

{%- set enum_name = enum|get_name_for_kind(flatten_nested_kind=True) %}

struct {{enum_name}}_Data {

public:

- static bool const kIsExtensible = {% if enum.extensible %}true{% else %}false{% endif %};

+ static bool constexpr kIsExtensible = {% if enum.extensible %}true{% else %}false{% endif %};

static bool IsKnownValue(int32_t value) {

{%- if enum.fields %}