mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl - Issue 2637393002: Make mojom-generated C++ string constants really constant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

Issue 2637393002: Make mojom-generated C++ string constants really constant. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/module-shared-internal.h.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

index 875684403fa8d9d49e347d557676d761841911cf..97044cafabd22f4950f11a9340fe990ac2d5d764 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

@@ -42,14 +42,11 @@ std::move(p_{{param.name}})

{#--- Begin #}

const char {{class_name}}::Name_[] = "{{namespace_as_string}}::{{class_name}}";

-const uint32_t {{class_name}}::Version_;

{#--- Constants #}

{%- for constant in interface.constants %}

-{%- if constant.kind|is_integral_kind %}

-const {{constant.kind|cpp_pod_type}} {{interface.name}}::{{constant.name}};

-{%- else %}

-const {{constant.kind|cpp_pod_type}} {{interface.name}}::{{constant.name}} = {{constant|constant_value}};

+{%- if constant.kind|is_string_kind %}

+const char {{interface.name}}::{{constant.name}}[] = {{constant|constant_value}};

{%- endif %}

{%- endfor %}