Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: mojo/public/interfaces/bindings/tests/test_constants.mojom

Issue 2637393002: Make mojom-generated C++ string constants really constant. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/interfaces/bindings/tests/test_constants.mojom
diff --git a/mojo/public/interfaces/bindings/tests/test_constants.mojom b/mojo/public/interfaces/bindings/tests/test_constants.mojom
index 462d5126a5a8d76b9292ccc3c678eb872bb6f661..272e6035a6fed1842a4d1eb0789a70c5c2f769e8 100644
--- a/mojo/public/interfaces/bindings/tests/test_constants.mojom
+++ b/mojo/public/interfaces/bindings/tests/test_constants.mojom
@@ -42,12 +42,16 @@ const float kFloatInfinity = float.INFINITY;
const float kFloatNegativeInfinity = float.NEGATIVE_INFINITY;
const float kFloatNaN = float.NAN;
+const string kStringValue = "test string contents";
+
struct StructWithConstants {
const int8 kInt8Value = 5;
const float kFloatValue = 765.432;
+ const string kStringValue = "struct test string contents";
};
interface InterfaceWithConstants {
const uint32 kUint32Value = 20100722;
const double kDoubleValue = 12.34567;
+ const string kStringValue = "interface test string contents";
};

Powered by Google App Engine
This is Rietveld 408576698