mojo/public/tools/bindings/generators/cpp_templates/module-shared-internal.h.tmpl - Issue 2637393002: Make mojom-generated C++ string constants really constant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/module-shared-internal.h.tmpl

Issue 2637393002: Make mojom-generated C++ string constants really constant. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/module-shared.h.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/module-shared-internal.h.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/module-shared-internal.h.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/module-shared-internal.h.tmpl

index f718276c2a9f370886c9b243d0c8618415f184d3..964b25438e27b10cbaa00b89c5c2a3d03751d202 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/module-shared-internal.h.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/module-shared-internal.h.tmpl

@@ -76,7 +76,7 @@ using {{enum|get_name_for_kind(flatten_nested_kind=True)}}_Data =

{%- for interface in interfaces %}

{%- for method in interface.methods %}

{%- set method_name = "k%s_%s_Name"|format(interface.name, method.name) %}

-const uint32_t {{method_name}} = {{method.ordinal}};

+constexpr uint32_t {{method_name}} = {{method.ordinal}};

{%- set struct = method.param_struct %}

{% include "struct_declaration.tmpl" %}

{%- if method.response_parameters != None %}