mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl - Issue 2637393002: Make mojom-generated C++ string constants really constant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl

Issue 2637393002: Make mojom-generated C++ string constants really constant. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl

index 374b0976b1831b66b13f96b0674ba0b07fd5a538..60dca4010e0e877119c4db71f6d05c61624950e2 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl

@@ -15,7 +15,7 @@ bool {{class_name}}::Validate(

// the message comes from an older version.

const {{class_name}}* object = static_cast<const {{class_name}}*>(data);

- static const struct {

+ static constexpr struct {

uint32_t version;

uint32_t num_bytes;

} kVersionSizes[] = {