Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 234002: More work in Command Buffers... (Closed)

Created:
11 years, 3 months ago by gman
Modified:
9 years, 7 months ago
Reviewers:
rlp, petersont
CC:
o3d-review_googlegroups.com
Visibility:
Public.

Description

More work in Command Buffers I think/hope this is the last big CL for this. *) Moved GAPIInterface enums to cmd_buffer_format.h The reason is you should not have to include CODE to make data. The fact that the enums were in GAPIInterface, a class, meant you had to include code if you wanted to make a command buffer. *) Typed arguments where I could. So for example Draw takes PrimitiveType instead of uint32. CreateVertexBuffer takes a ResourceId *) Renamed enums etc to match style guide. *) Moved BitFields into specific commands *) renamed arguments from id to type_id.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2241 lines, -2283 lines) Patch
M command_buffer/client/cross/big_test_client.cc View 7 chunks +25 lines, -23 lines 0 comments Download
M command_buffer/client/cross/cmd_buffer_helper.h View 17 chunks +129 lines, -118 lines 0 comments Download
M command_buffer/client/cross/effect_helper.h View 4 chunks +8 lines, -8 lines 0 comments Download
M command_buffer/client/cross/effect_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M command_buffer/client/cross/id_allocator.h View 1 chunk +3 lines, -3 lines 0 comments Download
M command_buffer/client/cross/id_allocator_test.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M command_buffer/common/cross/cmd_buffer_format.h View 107 chunks +878 lines, -853 lines 0 comments Download
M command_buffer/common/cross/gapi_interface.h View 42 chunks +48 lines, -136 lines 0 comments Download
M command_buffer/common/cross/resource.h View 5 chunks +61 lines, -58 lines 0 comments Download
M command_buffer/common/cross/resource.cc View 3 chunks +24 lines, -24 lines 0 comments Download
M command_buffer/samples/bubble/bubble_module.cc View 1 chunk +18 lines, -18 lines 0 comments Download
M command_buffer/service/cross/gapi_decoder.cc View 32 chunks +229 lines, -230 lines 0 comments Download
M command_buffer/service/cross/gl/effect_gl.h View 1 chunk +1 line, -1 line 0 comments Download
M command_buffer/service/cross/gl/effect_gl.cc View 17 chunks +80 lines, -79 lines 0 comments Download
M command_buffer/service/cross/gl/gapi_gl.h View 11 chunks +52 lines, -52 lines 0 comments Download
M command_buffer/service/cross/gl/gapi_gl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M command_buffer/service/cross/gl/geometry_gl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M command_buffer/service/cross/gl/geometry_gl.cc View 18 chunks +40 lines, -40 lines 0 comments Download
M command_buffer/service/cross/gl/render_surface_gl.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M command_buffer/service/cross/gl/sampler_gl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M command_buffer/service/cross/gl/sampler_gl.cc View 11 chunks +31 lines, -31 lines 0 comments Download
M command_buffer/service/cross/gl/states_gl.cc View 10 chunks +39 lines, -36 lines 0 comments Download
M command_buffer/service/cross/gl/texture_gl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M command_buffer/service/cross/gl/texture_gl.cc View 8 chunks +16 lines, -16 lines 0 comments Download
M command_buffer/service/cross/resource.h View 4 chunks +7 lines, -7 lines 0 comments Download
M command_buffer/service/cross/resource.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M command_buffer/service/win/d3d9/d3d9_utils.h View 1 chunk +9 lines, -6 lines 0 comments Download
M command_buffer/service/win/d3d9/effect_d3d9.h View 1 chunk +1 line, -1 line 0 comments Download
M command_buffer/service/win/d3d9/effect_d3d9.cc View 14 chunks +41 lines, -41 lines 0 comments Download
M command_buffer/service/win/d3d9/gapi_d3d9.h View 12 chunks +52 lines, -52 lines 0 comments Download
M command_buffer/service/win/d3d9/gapi_d3d9.cc View 4 chunks +13 lines, -12 lines 0 comments Download
M command_buffer/service/win/d3d9/geometry_d3d9.h View 2 chunks +2 lines, -2 lines 0 comments Download
M command_buffer/service/win/d3d9/geometry_d3d9.cc View 18 chunks +29 lines, -29 lines 0 comments Download
M command_buffer/service/win/d3d9/render_surface_d3d9.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M command_buffer/service/win/d3d9/sampler_d3d9.h View 2 chunks +2 lines, -2 lines 0 comments Download
M command_buffer/service/win/d3d9/sampler_d3d9.cc View 9 chunks +21 lines, -21 lines 0 comments Download
M command_buffer/service/win/d3d9/states_d3d9.cc View 3 chunks +80 lines, -73 lines 0 comments Download
M command_buffer/service/win/d3d9/texture_d3d9.h View 3 chunks +3 lines, -3 lines 0 comments Download
M command_buffer/service/win/d3d9/texture_d3d9.cc View 14 chunks +22 lines, -22 lines 0 comments Download
M core/cross/command_buffer/buffer_cb.h View 4 chunks +4 lines, -4 lines 0 comments Download
M core/cross/command_buffer/buffer_cb.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M core/cross/command_buffer/effect_cb.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/cross/command_buffer/effect_cb.cc View 4 chunks +14 lines, -14 lines 0 comments Download
M core/cross/command_buffer/param_cache_cb.h View 1 chunk +1 line, -1 line 0 comments Download
M core/cross/command_buffer/param_cache_cb.cc View 8 chunks +16 lines, -16 lines 0 comments Download
M core/cross/command_buffer/primitive_cb.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M core/cross/command_buffer/render_surface_cb.h View 2 chunks +4 lines, -4 lines 0 comments Download
M core/cross/command_buffer/render_surface_cb.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M core/cross/command_buffer/renderer_cb.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M core/cross/command_buffer/sampler_cb.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/cross/command_buffer/sampler_cb.cc View 4 chunks +15 lines, -15 lines 0 comments Download
M core/cross/command_buffer/states_cb.cc View 8 chunks +120 lines, -125 lines 0 comments Download
M core/cross/command_buffer/stream_bank_cb.h View 1 chunk +1 line, -1 line 0 comments Download
M core/cross/command_buffer/stream_bank_cb.cc View 4 chunks +14 lines, -14 lines 0 comments Download
M core/cross/command_buffer/texture_cb.h View 6 chunks +6 lines, -6 lines 0 comments Download
M core/cross/command_buffer/texture_cb.cc View 14 chunks +24 lines, -28 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
gman
11 years, 3 months ago (2009-09-24 02:09:07 UTC) #1
rlp
11 years, 3 months ago (2009-09-25 22:43:30 UTC) #2
LGTM

I think moving the enums from gapi to cmd_buffer_format was a good idea. All of
these changes make the code much more readable and clear.

Powered by Google App Engine
This is Rietveld 408576698