First step towards making JumpTarget work on ARM. Instead...

First step towards making JumpTarget work on ARM.  Instead
of having a list of virtual frame pointers in the jump
target we have one virtual frame, which is the frame that
all have to merge to to branch to that frame.  The virtual
frame in the JumpTarget is inside the JumpTarget, rather than
being an allocated object that is pointed to.  Unfortunately
this means that the JumpTarget class has to be able to see
the size of a VirtualFrame object to compile, which in turn
lead to a major reorganization of related .h files.  The
actual change of functionality in this change is intended
to be minimal (we now assert that the virtual frames match
when using JumpTarget instead of just assuming that they do).

Committed: http://code.google.com/p/v8/source/detail?r=4631

[Søren Thygesen Gjesse, 2010-05-06 07:48:11]

LGTM

http://codereview.chromium.org/1961004/diff/1/20
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/1961004/diff/1/20#newcode49
src/arm/codegen-arm.cc:49: // These VirtualFrame methods should actually be in a
virtual-frame-arm-inl.h
Considered adding virtual-frame-arm-inl.h?

http://codereview.chromium.org/1961004/diff/1/24
File src/arm/jump-target-arm.cc (right):

http://codereview.chromium.org/1961004/diff/1/24#newcode55
src/arm/jump-target-arm.cc:55: // Use the current frame as the expected one at
the target if necessary.
Use the same comment "// Clone the current frame to use as the expected one at
the target." as is used below.

http://codereview.chromium.org/1961004/diff/1/24#newcode56
src/arm/jump-target-arm.cc:56: entry_frame_ = *cgen()->frame();
How about adding a function SetEntryFrame doing

  entry_frame_ = *cgen()->frame();
  entry_frame_set_ = true;

As this is done several times below?

http://codereview.chromium.org/1961004/diff/1/23
File src/arm/virtual-frame-arm.h (right):

http://codereview.chromium.org/1961004/diff/1/23#newcode462
src/arm/virtual-frame-arm.h:462: //friend class DeferredCode;
Friend in comment.

http://codereview.chromium.org/1961004/diff/1/11
File src/ia32/codegen-ia32.h (right):

http://codereview.chromium.org/1961004/diff/1/11#newcode32
src/ia32/codegen-ia32.h:32: #include "jump-target-heavy.h"
Sort includes.

http://codereview.chromium.org/1961004/diff/1/12
File src/ia32/virtual-frame-ia32.h (right):

http://codereview.chromium.org/1961004/diff/1/12#newcode33
src/ia32/virtual-frame-ia32.h:33: #include "scopes.h"
Sort includes.

http://codereview.chromium.org/1961004/diff/1/14
File src/jump-target-light.h (right):

http://codereview.chromium.org/1961004/diff/1/14#newcode132
src/jump-target-light.h:132: void DoBind();
private:
  DISALLOW_COPY_AND_ASSIGN?

http://codereview.chromium.org/1961004/diff/1/14#newcode181
src/jump-target-light.h:181: int expected_height_;
DISALLOW_COPY_AND_ASSIGN?

http://codereview.chromium.org/1961004/diff/1/10
File src/parser.cc (right):

http://codereview.chromium.org/1961004/diff/1/10#newcode41
src/parser.cc:41: 
Sort includes.

http://codereview.chromium.org/1961004/diff/1/18
File src/virtual-frame-light-inl.h (right):

http://codereview.chromium.org/1961004/diff/1/18#newcode121
src/virtual-frame-light-inl.h:121: 
Can these numbers in some way use the constants from frame-arm.h?

http://codereview.chromium.org/1961004/diff/1/17
File src/x64/codegen-x64.h (right):

http://codereview.chromium.org/1961004/diff/1/17#newcode32
src/x64/codegen-x64.h:32: #include "jump-target-heavy.h"
Sort includes alphabetically.

http://codereview.chromium.org/1961004/diff/1/16
File src/x64/virtual-frame-x64.h (right):

http://codereview.chromium.org/1961004/diff/1/16#newcode33
src/x64/virtual-frame-x64.h:33: #include "scopes.h"
Sort includes.

[Erik Corry, 2010-05-10 10:34:10]

All other comments done:

http://codereview.chromium.org/1961004/diff/1/14
File src/jump-target-light.h (right):

http://codereview.chromium.org/1961004/diff/1/14#newcode132
src/jump-target-light.h:132: void DoBind();
On 2010/05/06 07:48:11, Søren Gjesse wrote:
> private:
>   DISALLOW_COPY_AND_ASSIGN?

We actually do copy and assign them and I don't see big problems with that.

http://codereview.chromium.org/1961004/diff/1/10
File src/parser.cc (right):

http://codereview.chromium.org/1961004/diff/1/10#newcode41
src/parser.cc:41: 
On 2010/05/06 07:48:11, Søren Gjesse wrote:
> Sort includes.

I think it makes sense to have the -inl.h files after the others.

http://codereview.chromium.org/1961004/diff/1/18
File src/virtual-frame-light-inl.h (right):

http://codereview.chromium.org/1961004/diff/1/18#newcode121
src/virtual-frame-light-inl.h:121: 
On 2010/05/06 07:48:11, Søren Gjesse wrote:
> Can these numbers in some way use the constants from frame-arm.h?

I tried this but it got much uglier (this code is only moved, not written by
me).  Those constants are in terms of bytes, not in terms of words, and don't
have very helpful names in terms of the way they are used here.  I lack the
insight to create a more coherent naming and organization in this part of the
VM.