Add CHECKs to the ResourceHandler derived classes to see which is returning a NULL IOBuffer:data_.

Add CHECKs to the ResourceHandler derived classes to see which is returning a NULL IOBuffer:data_.
BUG=http://crbug.com/16371

[willchan no longer on Chromium, 2009-07-29 01:16:20]

I might have been overzealous in adding CHECKs, but I figured it was better to
add more rather than wait an extra week to find out.

[rvargas (doing something else), 2009-07-29 02:26:20]

It would be good to have a todo somewhere about removing the checks Maybe point
to this review so that we don't miss them later?

Other than that looks good.

http://codereview.chromium.org/159561/diff/10/1009
File chrome/browser/renderer_host/async_resource_handler.cc (right):

http://codereview.chromium.org/159561/diff/10/1009#newcode16
Line 16: static SharedIOBuffer* g_spare_read_buffer = NULL;
The header file is not part of this CL.

http://codereview.chromium.org/159561/diff/10/1009#newcode149
Line 149: tmp->Release();
A comment here about not hitting the destructor dcheck would be good.

http://codereview.chromium.org/159561/diff/10/1010
File chrome/browser/renderer_host/buffered_resource_handler.cc (right):

http://codereview.chromium.org/159561/diff/10/1010#newcode91
Line 91: *buf_size = kMaxBytesToSniff;
I guess you want to add another one here.

[willchan no longer on Chromium, 2009-07-29 03:05:49]

Woops, sorry about forgetting to upload the .h file.  I've added comments to all
the CHECKs now, and addressed the other nits.

On 2009/07/29 02:26:20, rvargas wrote:
> It would be good to have a todo somewhere about removing the checks Maybe
point
> to this review so that we don't miss them later?
> 
> Other than that looks good.
> 
> http://codereview.chromium.org/159561/diff/10/1009
> File chrome/browser/renderer_host/async_resource_handler.cc (right):
> 
> http://codereview.chromium.org/159561/diff/10/1009#newcode16
> Line 16: static SharedIOBuffer* g_spare_read_buffer = NULL;
> The header file is not part of this CL.
> 
> http://codereview.chromium.org/159561/diff/10/1009#newcode149
> Line 149: tmp->Release();
> A comment here about not hitting the destructor dcheck would be good.
> 
> http://codereview.chromium.org/159561/diff/10/1010
> File chrome/browser/renderer_host/buffered_resource_handler.cc (right):
> 
> http://codereview.chromium.org/159561/diff/10/1010#newcode91
> Line 91: *buf_size = kMaxBytesToSniff;
> I guess you want to add another one here.

[rvargas (doing something else), 2009-07-29 17:01:20]

LGTM