Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4120)

Unified Diff: chrome/browser/renderer_host/buffered_resource_handler.cc

Issue 159561: Add CHECKs to the ResourceHandler derived classes to see which is returning a NULL IOBuffer:data_. (Closed)
Patch Set: Add comments. Add missing .h file. Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/buffered_resource_handler.cc
diff --git a/chrome/browser/renderer_host/buffered_resource_handler.cc b/chrome/browser/renderer_host/buffered_resource_handler.cc
index cc9d2cb291059862652351c0c361ae78c1c188ab..8d0f17ffd9a0af9efb358428772d5bebd68ad44b 100644
--- a/chrome/browser/renderer_host/buffered_resource_handler.cc
+++ b/chrome/browser/renderer_host/buffered_resource_handler.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/renderer_host/buffered_resource_handler.h"
#include "base/histogram.h"
+#include "base/logging.h"
#include "base/string_util.h"
#include "net/base/mime_sniffer.h"
#include "net/base/net_errors.h"
@@ -88,6 +89,8 @@ bool BufferedResourceHandler::OnWillRead(int request_id, net::IOBuffer** buf,
my_buffer_ = new net::IOBuffer(kMaxBytesToSniff);
*buf = my_buffer_.get();
*buf_size = kMaxBytesToSniff;
+ // TODO(willchan): Remove after debugging bug 16371.
+ CHECK((*buf)->data());
return true;
}
@@ -98,6 +101,8 @@ bool BufferedResourceHandler::OnWillRead(int request_id, net::IOBuffer** buf,
return false;
}
read_buffer_ = *buf;
+ // TODO(willchan): Remove after debugging bug 16371.
+ CHECK(read_buffer_->data());
read_buffer_size_ = *buf_size;
DCHECK(read_buffer_size_ >= kMaxBytesToSniff * 2);
bytes_read_ = 0;
« no previous file with comments | « chrome/browser/renderer_host/async_resource_handler.cc ('k') | chrome/browser/renderer_host/cross_site_resource_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698