chrome/browser/renderer_host/download_throttling_resource_handler.cc - Issue 159561: Add CHECKs to the ResourceHandler derived classes to see which is returning a NULL IOBuffer:data_.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/download_throttling_resource_handler.cc

Issue 159561: Add CHECKs to the ResourceHandler derived classes to see which is returning a NULL IOBuffer:data_. (Closed)

Patch Set: Add comments. Add missing .h file. Created 11 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/download_resource_handler.cc ('k') | chrome/browser/renderer_host/safe_browsing_resource_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/download_throttling_resource_handler.cc

diff --git a/chrome/browser/renderer_host/download_throttling_resource_handler.cc b/chrome/browser/renderer_host/download_throttling_resource_handler.cc

index fb56384b8138ae6d7b4199fa4bee5273f083e2a0..f3ad5bbbd5120c674697d128cf93306b26e832eb 100644

--- a/chrome/browser/renderer_host/download_throttling_resource_handler.cc

+++ b/chrome/browser/renderer_host/download_throttling_resource_handler.cc

@@ -4,6 +4,7 @@

#include "chrome/browser/renderer_host/download_throttling_resource_handler.h"

+#include "base/logging.h"

#include "chrome/browser/renderer_host/download_resource_handler.h"

#include "net/base/io_buffer.h"

@@ -71,6 +72,8 @@ bool DownloadThrottlingResourceHandler::OnWillRead(int request_id,

min_size = 1024;

tmp_buffer_ = new net::IOBuffer(min_size);

*buf = tmp_buffer_.get();

+ // TODO(willchan): Remove after debugging bug 16371.

+ CHECK((*buf)->data());

*buf_size = min_size;

return true;

}