Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3182)

Unified Diff: chrome/browser/renderer_host/cross_site_resource_handler.cc

Issue 159561: Add CHECKs to the ResourceHandler derived classes to see which is returning a NULL IOBuffer:data_. (Closed)
Patch Set: Add comments. Add missing .h file. Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/cross_site_resource_handler.cc
diff --git a/chrome/browser/renderer_host/cross_site_resource_handler.cc b/chrome/browser/renderer_host/cross_site_resource_handler.cc
index fdb7d4a9794323357cce17ac303bb4bfb703f8ff..7b05a7269f572549487db956d8c048eca84a654a 100644
--- a/chrome/browser/renderer_host/cross_site_resource_handler.cc
+++ b/chrome/browser/renderer_host/cross_site_resource_handler.cc
@@ -6,8 +6,10 @@
#include "chrome/browser/renderer_host/cross_site_resource_handler.h"
+#include "base/logging.h"
#include "base/message_loop.h"
#include "chrome/browser/renderer_host/render_view_host.h"
+#include "net/base/io_buffer.h"
namespace {
@@ -123,7 +125,11 @@ bool CrossSiteResourceHandler::OnResponseStarted(int request_id,
bool CrossSiteResourceHandler::OnWillRead(int request_id, net::IOBuffer** buf,
int* buf_size, int min_size) {
- return next_handler_->OnWillRead(request_id, buf, buf_size, min_size);
+ bool rv = next_handler_->OnWillRead(request_id, buf, buf_size, min_size);
+ // TODO(willchan): Remove after debugging bug 16371.
+ if (rv)
+ CHECK((*buf)->data());
+ return rv;
}
bool CrossSiteResourceHandler::OnReadCompleted(int request_id,
« no previous file with comments | « chrome/browser/renderer_host/buffered_resource_handler.cc ('k') | chrome/browser/renderer_host/download_resource_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698