Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/browser/renderer_host/safe_browsing_resource_handler.cc

Issue 159561: Add CHECKs to the ResourceHandler derived classes to see which is returning a NULL IOBuffer:data_. (Closed)
Patch Set: Add comments. Add missing .h file. Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/safe_browsing_resource_handler.cc
diff --git a/chrome/browser/renderer_host/safe_browsing_resource_handler.cc b/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
index 583a6ddbc1cddcffd7c446cfcc0e125865a33d3e..0d2af57db0af0e5036c31ced0e7ac5d802353fb5 100644
--- a/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
+++ b/chrome/browser/renderer_host/safe_browsing_resource_handler.cc
@@ -4,10 +4,12 @@
#include "chrome/browser/renderer_host/safe_browsing_resource_handler.h"
+#include "base/logging.h"
#include "chrome/browser/renderer_host/resource_dispatcher_host.h"
#include "chrome/browser/renderer_host/resource_message_filter.h"
#include "chrome/common/notification_service.h"
#include "net/base/net_errors.h"
+#include "net/base/io_buffer.h"
// Maximum time to wait for a gethash response from the Safe Browsing servers.
static const int kMaxGetHashMs = 1000;
@@ -103,7 +105,11 @@ bool SafeBrowsingResourceHandler::OnWillRead(int request_id,
paused_request_id_ = request_id;
}
- return next_handler_->OnWillRead(request_id, buf, buf_size, min_size);
+ bool rv = next_handler_->OnWillRead(request_id, buf, buf_size, min_size);
+ // TODO(willchan): Remove after debugging bug 16371.
+ if (rv)
+ CHECK((*buf)->data());
+ return rv;
}
bool SafeBrowsingResourceHandler::OnReadCompleted(int request_id,
@@ -205,4 +211,3 @@ void SafeBrowsingResourceHandler::Observe(NotificationType type,
Release();
}
}
-

Powered by Google App Engine
This is Rietveld 408576698