Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: chrome/browser/renderer_host/save_file_resource_handler.cc

Issue 159561: Add CHECKs to the ResourceHandler derived classes to see which is returning a NULL IOBuffer:data_. (Closed)
Patch Set: Add comments. Add missing .h file. Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/renderer_host/save_file_resource_handler.h" 5 #include "chrome/browser/renderer_host/save_file_resource_handler.h"
6 6
7 #include "base/logging.h"
7 #include "base/message_loop.h" 8 #include "base/message_loop.h"
8 #include "base/string_util.h" 9 #include "base/string_util.h"
9 #include "chrome/browser/download/save_file_manager.h" 10 #include "chrome/browser/download/save_file_manager.h"
10 #include "net/base/io_buffer.h" 11 #include "net/base/io_buffer.h"
11 12
12 SaveFileResourceHandler::SaveFileResourceHandler(int render_process_host_id, 13 SaveFileResourceHandler::SaveFileResourceHandler(int render_process_host_id,
13 int render_view_id, 14 int render_view_id,
14 const GURL& url, 15 const GURL& url,
15 SaveFileManager* manager) 16 SaveFileManager* manager)
16 : save_id_(-1), 17 : save_id_(-1),
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 } 50 }
50 51
51 bool SaveFileResourceHandler::OnWillRead(int request_id, net::IOBuffer** buf, 52 bool SaveFileResourceHandler::OnWillRead(int request_id, net::IOBuffer** buf,
52 int* buf_size, int min_size) { 53 int* buf_size, int min_size) {
53 DCHECK(buf && buf_size); 54 DCHECK(buf && buf_size);
54 if (!read_buffer_) { 55 if (!read_buffer_) {
55 *buf_size = min_size < 0 ? kReadBufSize : min_size; 56 *buf_size = min_size < 0 ? kReadBufSize : min_size;
56 read_buffer_ = new net::IOBuffer(*buf_size); 57 read_buffer_ = new net::IOBuffer(*buf_size);
57 } 58 }
58 *buf = read_buffer_.get(); 59 *buf = read_buffer_.get();
60 // TODO(willchan): Remove after debugging bug 16371.
61 CHECK(read_buffer_->data());
59 return true; 62 return true;
60 } 63 }
61 64
62 bool SaveFileResourceHandler::OnReadCompleted(int request_id, int* bytes_read) { 65 bool SaveFileResourceHandler::OnReadCompleted(int request_id, int* bytes_read) {
63 DCHECK(read_buffer_); 66 DCHECK(read_buffer_);
64 // We are passing ownership of this buffer to the save file manager. 67 // We are passing ownership of this buffer to the save file manager.
65 net::IOBuffer* buffer = NULL; 68 net::IOBuffer* buffer = NULL;
66 read_buffer_.swap(&buffer); 69 read_buffer_.swap(&buffer);
67 save_manager_->GetSaveLoop()->PostTask(FROM_HERE, 70 save_manager_->GetSaveLoop()->PostTask(FROM_HERE,
68 NewRunnableMethod(save_manager_, 71 NewRunnableMethod(save_manager_,
(...skipping 16 matching lines...) Expand all
85 render_process_id_, 88 render_process_id_,
86 status.is_success() && !status.is_io_pending())); 89 status.is_success() && !status.is_io_pending()));
87 read_buffer_ = NULL; 90 read_buffer_ = NULL;
88 return true; 91 return true;
89 } 92 }
90 93
91 void SaveFileResourceHandler::set_content_length( 94 void SaveFileResourceHandler::set_content_length(
92 const std::string& content_length) { 95 const std::string& content_length) {
93 content_length_ = StringToInt64(content_length); 96 content_length_ = StringToInt64(content_length);
94 } 97 }
OLDNEW
« no previous file with comments | « chrome/browser/renderer_host/safe_browsing_resource_handler.cc ('k') | chrome/browser/renderer_host/sync_resource_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698