Issue 1432003: Minor C++ fixes found by Clang.

Issue 1432003: Minor C++ fixes found by Clang. (Closed)

Created:
10 years, 9 months ago by Evan Martin

Modified:
10 years, 8 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, ncarter (slow), fbarchard, Alpha Left Google, idana, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, brettw-cc_chromium.org, Aaron Boodman, dpranke+watch_chromium.org, pam+watch_chromium.org, awong, Paweł Hajdan Jr., darin-cc_chromium.org, tim (not reviewing), scherkus (not reviewing)

Visibility:
Public.

Description

Minor C++ fixes found by Clang. In cases where I've added an #include, it's generally due to Clang being more picky about templates being available during expansions. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43098

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Total comments: 4

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -36 lines)			Patch
M	base/process_util_posix.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	base/tuple_unittest.cc	View	2 chunks	+3 lines, -1 line	1 comment	Download
M	chrome/browser/autofill/autofill_xml_parser.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_accessibility_api_constants.cc	View	1 chunk	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/sessions/tab_restore_service.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/extensions/extension_message_bundle.h	View	1 chunk	+1 line, -0 lines	1 comment	Download
M	chrome/common/process_watcher_posix.cc	View	1 chunk	+2 lines, -1 line	1 comment	Download
M	chrome/tools/build/make_version_cc.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/audio/linux/alsa_output.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	printing/pdf_ps_metafile_cairo.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	printing/pdf_ps_metafile_cairo.cc	View	1 chunk	+5 lines, -2 lines	1 comment	Download
M	third_party/libjingle/files/talk/base/stringutils.h	View	2 chunks	+9 lines, -9 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_switches.cc	View	1 chunk	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

http://codereview.chromium.org/1432003/diff/1/14 File third_party/libjingle/files/talk/base/stringutils.h (right): http://codereview.chromium.org/1432003/diff/1/14#newcode217 third_party/libjingle/files/talk/base/stringutils.h:217: size_t len = vsprintfn(buffer, buflen, format, args); This needed ...

10 years, 8 months ago (2010-03-30 16:47:47 UTC) #1

willchan no longer on Chromium

10 years, 8 months ago (2010-03-30 17:13:18 UTC) #2

lgtm

http://codereview.chromium.org/1432003/diff/2001/3002
File base/tuple_unittest.cc (right):

http://codereview.chromium.org/1432003/diff/2001/3002#newcode33
base/tuple_unittest.cc:33: Tuple0 t0 ALLOW_UNUSED = MakeTuple();
I don't much care, but I'm not sure of the point of storing a Tuple0 into a
variable.  Just calling 0-arg MakeTuple() seems enough to me.  Whatever though.

http://codereview.chromium.org/1432003/diff/2001/3006
File chrome/common/extensions/extension_message_bundle.h (right):

http://codereview.chromium.org/1432003/diff/2001/3006#newcode24
chrome/common/extensions/extension_message_bundle.h:24: static const wchar_t*
kContentKey;
ew, none of these are constants :(

http://codereview.chromium.org/1432003/diff/2001/3007
File chrome/common/process_watcher_posix.cc (right):

http://codereview.chromium.org/1432003/diff/2001/3007#newcode69
chrome/common/process_watcher_posix.cc:69: PLOG(WARNING) << "waitpid";
Hm, we should probably #include "base/logging.h" for this.  I guess we're
probably pulling it in from some other header, but there's no guarantee that
won't be removed at some point.

http://codereview.chromium.org/1432003/diff/2001/3010
File printing/pdf_ps_metafile_cairo.cc (right):

http://codereview.chromium.org/1432003/diff/2001/3010#newcode362
printing/pdf_ps_metafile_cairo.cc:362: if (HANDLE_EINTR(close(fd.fd)) < 0)
It's probably a good idea to PLOG here too.

Expand Messages | Collapse Messages