Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Unified Diff: chrome/common/process_watcher_posix.cc

Issue 1432003: Minor C++ fixes found by Clang. (Closed)
Patch Set: rebase Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/process_watcher_posix.cc
diff --git a/chrome/common/process_watcher_posix.cc b/chrome/common/process_watcher_posix.cc
index c0ea178d2c8c81a814d40a0f20400efd94ae7f74..162d09c6a18cfad9ee33c65f7e45a34a7e788b40 100644
--- a/chrome/common/process_watcher_posix.cc
+++ b/chrome/common/process_watcher_posix.cc
@@ -65,7 +65,8 @@ class BackgroundReaper : public PlatformThread::Delegate {
if (kill(child_, SIGKILL) == 0) {
// SIGKILL is uncatchable. Since the signal was delivered, we can
// just wait for the process to die now in a blocking manner.
- HANDLE_EINTR(waitpid(child_, NULL, 0));
+ if (HANDLE_EINTR(waitpid(child_, NULL, 0)) < 0)
+ PLOG(WARNING) << "waitpid";
willchan no longer on Chromium 2010/03/30 17:13:18 Hm, we should probably #include "base/logging.h" f
} else {
LOG(ERROR) << "While waiting for " << child_ << " to terminate we"
<< " failed to deliver a SIGKILL signal (" << errno << ").";

Powered by Google App Engine
This is Rietveld 408576698