printing/pdf_ps_metafile_cairo.cc - Issue 1432003: Minor C++ fixes found by Clang.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: printing/pdf_ps_metafile_cairo.cc

Issue 1432003: Minor C++ fixes found by Clang. (Closed)

Patch Set: rebase Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: printing/pdf_ps_metafile_cairo.cc

diff --git a/printing/pdf_ps_metafile_cairo.cc b/printing/pdf_ps_metafile_cairo.cc

index 31c1e8a3aa6d89869d7d88450ae379258b238eef..e0aec8a8497db30148a86eaeaa219676b488d394 100644

--- a/printing/pdf_ps_metafile_cairo.cc

+++ b/printing/pdf_ps_metafile_cairo.cc

@@ -358,8 +358,11 @@ bool PdfPsMetafile::SaveTo(const base::FileDescriptor& fd) const {

success = false;

}

- if (fd.auto_close)

- HANDLE_EINTR(close(fd.fd));

+ if (fd.auto_close) {

+ if (HANDLE_EINTR(close(fd.fd)) < 0)

willchan no longer on Chromium 2010/03/30 17:13:18 It's probably a good idea to PLOG here too.

+ success = false;

+ }

return success;

}