Minor C++ fixes found by Clang.

base/tuple_unittest.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/tuple.h"
+
+#include "base/compiler_specific.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
 void DoAdd(int a, int b, int c, int* res) {
   *res = a + b + c;
 }
 
 struct Addy {
   Addy() { }
   void DoAdd(int a, int b, int c, int d, int* res) {
     *res = a + b + c + d;
   }
 };
 
 struct Addz {
   Addz() { }
   void DoAdd(int a, int b, int c, int d, int e, int* res) {
     *res = a + b + c + d + e;
   }
 };
 
 }  // namespace
 
 TEST(TupleTest, Basic) {
-  Tuple0 t0 = MakeTuple();
+  Tuple0 t0 ALLOW_UNUSED = MakeTuple();

[willchan no longer on Chromium, 2010/03/30 17:13:18]

I don't much care, but I'm not sure of the point of storing a Tuple0 into a
variable.  Just calling 0-arg MakeTuple() seems enough to me.  Whatever though.

   Tuple1<int> t1(1);
   Tuple2<int, const char*> t2 = MakeTuple(1, static_cast<const char*>("wee"));
   Tuple3<int, int, int> t3(1, 2, 3);
   Tuple4<int, int, int, int*> t4(1, 2, 3, &t1.a);
   Tuple5<int, int, int, int, int*> t5(1, 2, 3, 4, &t4.a);
   Tuple6<int, int, int, int, int, int*> t6(1, 2, 3, 4, 5, &t4.a);
 
   EXPECT_EQ(1, t1.a);
   EXPECT_EQ(1, t2.a);
   EXPECT_EQ(1, t3.a);
@@ skipping 75 matching lines @@
   EXPECT_EQ(2, CopyLogger::TimesConstructed);
   EXPECT_EQ(1, CopyLogger::TimesCopied);
 
   // Now they should be different, since the function call will make a copy.
   res = false;
   DispatchToFunction(&SomeLoggerMethCopy, tuple);
   EXPECT_FALSE(res);
   EXPECT_EQ(3, CopyLogger::TimesConstructed);
   EXPECT_EQ(2, CopyLogger::TimesCopied);
 }