Minor C++ fixes found by Clang.

chrome/common/process_watcher_posix.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/process_watcher.h"
 
 #include <errno.h>
 #include <signal.h>
 #include <sys/types.h>
 #include <sys/wait.h>
@@ skipping 47 matching lines @@
     // Wait for 2 * timeout_ 500 milliseconds intervals.
     for (unsigned i = 0; i < 2 * timeout_; ++i) {
       PlatformThread::Sleep(500);  // 0.5 seconds
       if (IsChildDead(child_))
         return;
     }
 
     if (kill(child_, SIGKILL) == 0) {
       // SIGKILL is uncatchable. Since the signal was delivered, we can
       // just wait for the process to die now in a blocking manner.
-      HANDLE_EINTR(waitpid(child_, NULL, 0));
+      if (HANDLE_EINTR(waitpid(child_, NULL, 0)) < 0)
+        PLOG(WARNING) << "waitpid";

[willchan no longer on Chromium, 2010/03/30 17:13:18]

Hm, we should probably #include "base/logging.h" for this.  I guess we're
probably pulling it in from some other header, but there's no guarantee that
won't be removed at some point.

     } else {
       LOG(ERROR) << "While waiting for " << child_ << " to terminate we"
                  << " failed to deliver a SIGKILL signal (" << errno << ").";
     }
   }
 
  private:
   const pid_t child_;
   // Number of seconds to wait, if 0 then wait forever and do not attempt to
   // kill |child_|.
@@ skipping 15 matching lines @@
 
 // static
 void ProcessWatcher::EnsureProcessGetsReaped(base::ProcessHandle process) {
   // If the child is already dead, then there's nothing to do.
   if (IsChildDead(process))
     return;
 
   BackgroundReaper* reaper = new BackgroundReaper(process, 0);
   PlatformThread::CreateNonJoinable(0, reaper);
 }