Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/tools/build/make_version_cc.py

Issue 1432003: Minor C++ fixes found by Clang. (Closed)
Patch Set: rebase Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/common/process_watcher_posix.cc ('K') | « chrome/common/process_watcher_posix.cc ('k') | media/audio/linux/alsa_output.h » ('j') | printing/pdf_ps_metafile_cairo.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/tools/build/make_version_cc.py
diff --git a/chrome/tools/build/make_version_cc.py b/chrome/tools/build/make_version_cc.py
index 2797595981b113556358c17142bf5eb778e26fc4..b59fdd7d88897f8f4f94531c42d93bb0e13c878a 100755
--- a/chrome/tools/build/make_version_cc.py
+++ b/chrome/tools/build/make_version_cc.py
@@ -20,7 +20,7 @@ def main(me, args):
namespace chrome {
-extern const char kChromeVersion[] = "%s";
+const char kChromeVersion[] = "%s";
} // namespace chrome
''' % (me, version)
« chrome/common/process_watcher_posix.cc ('K') | « chrome/common/process_watcher_posix.cc ('k') | media/audio/linux/alsa_output.h » ('j') | printing/pdf_ps_metafile_cairo.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698