RefCounted types should not have public destructors, base/ edition

RefCounted types should not have public destructors, base/ edition

BUG=123295
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133825

[Ryan Sleevi, 2012-04-13 08:50:53]

jar: PTAL

[jar (doing other things), 2012-04-14 01:09:38]

One small nit.

LGTM

http://codereview.chromium.org/10065037/diff/1/base/threading/worker_pool_uni...
File base/threading/worker_pool_unittest.cc (right):

http://codereview.chromium.org/10065037/diff/1/base/threading/worker_pool_uni...
base/threading/worker_pool_unittest.cc:27: PostTaskAndReplyTester() :
finished_(false), test_event_(false, false) {}
nit: This file doesn't seem to use {} on one line... so match the style. (it
also lets you avoid changin' the code ;-) ).

[Ryan Sleevi, 2012-04-24 22:26:01]

Note that I'm taking a liberal interpretation of
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Declar...
here, which states

"Friend declarations should always be in the private section", by interpreting
that "should" as an IETF-style SHOULD rather than a MUST ;-) Frankly, we do this
so liberally that if needed, we should put a style exception in the Chromium
style guide, much like
http://dev.chromium.org/developers/coding-style#TOC-Code-formatting reads

"Other formatting "rules" are not required, but are fairly common across Chrome
code, and thus it's probably best to stick to them unless you have a reason not
to.  In particular, if existing code follows these styles, maintain them:" ...
"Function declaration order should match function definition order"

http://codereview.chromium.org/10065037/diff/1/base/threading/worker_pool_uni...
File base/threading/worker_pool_unittest.cc (right):

http://codereview.chromium.org/10065037/diff/1/base/threading/worker_pool_uni...
base/threading/worker_pool_unittest.cc:27: PostTaskAndReplyTester() :
finished_(false), test_event_(false, false) {}
On 2012/04/14 01:09:38, jar wrote:
> nit: This file doesn't seem to use {} on one line... so match the style. (it
> also lets you avoid changin' the code ;-) ).

In the spirit of unnecessary changes because the style guide said so -
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Constr...

Gives two (and only two) canonical forms. This has been updated to reflect the
first of the Two True Forms.

[commit-bot: I haz the power, 2012-04-24 22:26:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10065037/8001

[commit-bot: I haz the power, 2012-04-24 22:44:09]

Try job failure for 10065037-8001 (retry) on android for steps "Compile, build".
It's a second try, previously, steps "Compile, build" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...

[commit-bot: I haz the power, 2012-04-24 22:52:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10065037/5004

[commit-bot: I haz the power, 2012-04-25 00:42:53]

Change committed as 133825