Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2831)

Unified Diff: base/threading/sequenced_worker_pool_unittest.cc

Issue 10065037: RefCounted types should not have public destructors, base/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Typo fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/message_loop_unittest.cc ('k') | base/threading/worker_pool_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/threading/sequenced_worker_pool_unittest.cc
diff --git a/base/threading/sequenced_worker_pool_unittest.cc b/base/threading/sequenced_worker_pool_unittest.cc
index 42cf8596f13fb0cef5ad3ae2809bae0f1fe582cb..54ca01dba0c173b64c82124a971ed4b056c0acc6 100644
--- a/base/threading/sequenced_worker_pool_unittest.cc
+++ b/base/threading/sequenced_worker_pool_unittest.cc
@@ -37,8 +37,7 @@ const size_t kNumWorkerThreads = 3;
// provides a way to unblock a certain number of them.
class ThreadBlocker {
public:
- ThreadBlocker() : lock_(), cond_var_(&lock_), unblock_counter_(0) {
- }
+ ThreadBlocker() : lock_(), cond_var_(&lock_), unblock_counter_(0) {}
void Block() {
{
@@ -79,6 +78,7 @@ class TestTracker : public base::RefCountedThreadSafe<TestTracker> {
void FastTask(int id) {
SignalWorkerDone(id);
}
+
void SlowTask(int id) {
base::PlatformThread::Sleep(base::TimeDelta::FromSeconds(1));
SignalWorkerDone(id);
@@ -128,6 +128,9 @@ class TestTracker : public base::RefCountedThreadSafe<TestTracker> {
}
private:
+ friend class base::RefCountedThreadSafe<TestTracker>;
+ ~TestTracker() {}
+
void SignalWorkerDone(int id) {
{
base::AutoLock lock(lock_);
@@ -152,7 +155,8 @@ class SequencedWorkerPoolTest : public testing::Test {
public:
SequencedWorkerPoolTest()
: pool_owner_(kNumWorkerThreads, "test"),
- tracker_(new TestTracker) {}
+ tracker_(new TestTracker) {
+ }
virtual ~SequencedWorkerPoolTest() {}
« no previous file with comments | « base/message_loop_unittest.cc ('k') | base/threading/worker_pool_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698