RefCounted types should not have public destructors, base/ edition

base/threading/sequenced_worker_pool_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/threading/sequenced_worker_pool.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
@@ skipping 19 matching lines @@
 // mark as flaky if they're hanging, it's likely an actual bug.
 
 namespace {
 
 const size_t kNumWorkerThreads = 3;
 
 // Allows a number of threads to all be blocked on the same event, and
 // provides a way to unblock a certain number of them.
 class ThreadBlocker {
  public:
-  ThreadBlocker() : lock_(), cond_var_(&lock_), unblock_counter_(0) {
-  }
+  ThreadBlocker() : lock_(), cond_var_(&lock_), unblock_counter_(0) {}
 
   void Block() {
     {
       base::AutoLock lock(lock_);
       while (unblock_counter_ == 0)
         cond_var_.Wait();
       unblock_counter_--;
     }
     cond_var_.Signal();
   }
@@ skipping 20 matching lines @@
       : lock_(),
         cond_var_(&lock_),
         started_events_(0) {
   }
 
   // Each of these tasks appends the argument to the complete sequence vector
   // so calling code can see what order they finished in.
   void FastTask(int id) {
     SignalWorkerDone(id);
   }
+
   void SlowTask(int id) {
     base::PlatformThread::Sleep(base::TimeDelta::FromSeconds(1));
     SignalWorkerDone(id);
   }
 
   void BlockTask(int id, ThreadBlocker* blocker) {
     // Note that this task has started and signal anybody waiting for that
     // to happen.
     {
       base::AutoLock lock(lock_);
@@ skipping 29 matching lines @@
     return ret;
   }
 
   void ClearCompleteSequence() {
     base::AutoLock lock(lock_);
     complete_sequence_.clear();
     started_events_ = 0;
   }
 
  private:
+  friend class base::RefCountedThreadSafe<TestTracker>;
+  ~TestTracker() {}
+
   void SignalWorkerDone(int id) {
     {
       base::AutoLock lock(lock_);
       complete_sequence_.push_back(id);
     }
     cond_var_.Signal();
   }
 
   // Protects the complete_sequence.
   base::Lock lock_;
 
   base::ConditionVariable cond_var_;
 
   // Protected by lock_.
   std::vector<int> complete_sequence_;
 
   // Counter of the number of "block" workers that have started.
   size_t started_events_;
 };
 
 class SequencedWorkerPoolTest : public testing::Test {
  public:
   SequencedWorkerPoolTest()
       : pool_owner_(kNumWorkerThreads, "test"),
-        tracker_(new TestTracker) {}
+        tracker_(new TestTracker) {
+  }
 
   virtual ~SequencedWorkerPoolTest() {}
 
   virtual void SetUp() OVERRIDE {}
 
   virtual void TearDown() OVERRIDE {
     pool()->Shutdown();
   }
 
   const scoped_refptr<SequencedWorkerPool>& pool() {
@@ skipping 470 matching lines @@
     SequencedWorkerPoolSequencedTaskRunner, TaskRunnerTest,
     SequencedWorkerPoolSequencedTaskRunnerTestDelegate);
 
 INSTANTIATE_TYPED_TEST_CASE_P(
     SequencedWorkerPoolSequencedTaskRunner, SequencedTaskRunnerTest,
     SequencedWorkerPoolSequencedTaskRunnerTestDelegate);
 
 }  // namespace
 
 }  // namespace base