RefCounted types should not have public destructors, base/ edition

base/files/file_path_watcher_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file_path_watcher.h"
 
 #include <set>
 
 #if defined(OS_WIN)
 #include <windows.h>
@@ skipping 47 matching lines @@
 
   void Reset() {
     signaled_.clear();
   }
 
   bool Success() {
     return signaled_ == delegates_;
   }
 
  private:
+  friend class base::RefCountedThreadSafe<NotificationCollector>;
+  ~NotificationCollector() {}
+
   void RecordChange(TestDelegate* delegate) {
     ASSERT_TRUE(loop_->BelongsToCurrentThread());
     ASSERT_TRUE(delegates_.count(delegate));
     signaled_.insert(delegate);
 
     // Check whether all delegates have been signaled.
     if (signaled_ == delegates_)
       loop_->PostTask(FROM_HERE, MessageLoop::QuitClosure());
   }
 
@@ skipping 22 matching lines @@
   }
 
   virtual void OnFilePathChanged(const FilePath&) {
     collector_->OnChange(this);
   }
 
   virtual void OnFilePathError(const FilePath& path) {
     ADD_FAILURE() << "Error " << path.value();
   }
 
+ protected:
+  virtual ~TestDelegate() {}
+
  private:
   scoped_refptr<NotificationCollector> collector_;
 
   DISALLOW_COPY_AND_ASSIGN(TestDelegate);
 };
 
 void SetupWatchCallback(const FilePath& target,
                         FilePathWatcher* watcher,
                         FilePathWatcher::Delegate* delegate,
                         bool* result,
@@ skipping 122 matching lines @@
         loop_(loop) {
   }
 
   virtual void OnFilePathChanged(const FilePath& path) {
     watcher_.reset();
     loop_->PostTask(FROM_HERE, MessageLoop::QuitClosure());
   }
 
   scoped_ptr<FilePathWatcher> watcher_;
   MessageLoop* loop_;
+
+ private:
+  virtual ~Deleter() {}
 };
 
 // Verify that deleting a watcher during the callback doesn't crash.
 TEST_F(FilePathWatcherTest, DeleteDuringNotify) {
   FilePathWatcher* watcher = new FilePathWatcher;
   // Takes ownership of watcher.
   scoped_refptr<Deleter> deleter(new Deleter(watcher, &loop_));
   ASSERT_TRUE(SetupWatch(test_file(), watcher, deleter.get()));
 
   ASSERT_TRUE(WriteFile(test_file(), "content"));
@@ skipping 504 matching lines @@
   ASSERT_TRUE(ChangeFilePermissions(test_dir1, Execute, false));
   ASSERT_TRUE(WaitForEvents());
   ASSERT_TRUE(ChangeFilePermissions(test_dir1, Execute, true));
 }
 
 #endif  // OS_MACOSX
 }  // namespace
 
 }  // namespace files
 }  // namespace base