RefCounted types should not have public destructors, base/ edition

base/threading/worker_pool_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/threading/worker_pool.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/location.h"
 #include "base/message_loop.h"
 #include "base/test/test_timeouts.h"
 #include "base/time.h"
 #include "base/threading/thread_checker_impl.h"
 #include "base/synchronization/waitable_event.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "testing/platform_test.h"
 
 typedef PlatformTest WorkerPoolTest;
 
 namespace base {
 
 namespace {
 
 class PostTaskAndReplyTester
     : public base::RefCountedThreadSafe<PostTaskAndReplyTester> {
  public:
-  PostTaskAndReplyTester() : finished_(false), test_event_(false, false) {
-  }
+  PostTaskAndReplyTester() : finished_(false), test_event_(false, false) {}

[jar (doing other things), 2012/04/14 01:09:38]

nit: This file doesn't seem to use {} on one line... so match the style. (it
also lets you avoid changin' the code ;-) ).

[Ryan Sleevi, 2012/04/24 22:26:01]

In the spirit of unnecessary changes because the style guide said so -
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Constr...

Gives two (and only two) canonical forms. This has been updated to reflect the
first of the Two True Forms.

 
   void RunTest() {
     ASSERT_TRUE(thread_checker_.CalledOnValidThread());
     WorkerPool::PostTaskAndReply(
       FROM_HERE,
       base::Bind(&PostTaskAndReplyTester::OnWorkerThread, this),
       base::Bind(&PostTaskAndReplyTester::OnOriginalThread, this),
       false);
 
     test_event_.Wait();
   }
 
   void OnWorkerThread() {
     // We're not on the original thread.
     EXPECT_FALSE(thread_checker_.CalledOnValidThread());
 
     test_event_.Signal();
   }
 
   void OnOriginalThread() {
     EXPECT_TRUE(thread_checker_.CalledOnValidThread());
     finished_ = true;
   }
 
   bool finished() const {
     return finished_;
   }
 
  private:
+  friend class base::RefCountedThreadSafe<PostTaskAndReplyTester>;
+  ~PostTaskAndReplyTester() {}
+
   bool finished_;
   WaitableEvent test_event_;
 
   // The Impl version performs its checks even in release builds.
   ThreadCheckerImpl thread_checker_;
 };
 
 }  // namespace
 
 TEST_F(WorkerPoolTest, PostTask) {
@@ skipping 21 matching lines @@
   const TimeDelta kMaxDuration =
       TimeDelta::FromMilliseconds(TestTimeouts::tiny_timeout_ms());
   TimeTicks start = TimeTicks::Now();
   while (!tester->finished() && TimeTicks::Now() - start < kMaxDuration) {
     MessageLoop::current()->RunAllPending();
   }
   EXPECT_TRUE(tester->finished());
 }
 
 }  // namespace base