Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: base/memory/ref_counted_memory.h

Issue 10065037: RefCounted types should not have public destructors, base/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Typo fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/files/file_path_watcher_stub.cc ('k') | base/memory/ref_counted_memory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/memory/ref_counted_memory.h
diff --git a/base/memory/ref_counted_memory.h b/base/memory/ref_counted_memory.h
index 1434a901627cf59e8b3d1e278f1b989297c786d4..c9170f58bb19c699542699ab9e722e59601d1175 100644
--- a/base/memory/ref_counted_memory.h
+++ b/base/memory/ref_counted_memory.h
@@ -51,6 +51,8 @@ class BASE_EXPORT RefCountedStaticMemory : public RefCountedMemory {
virtual size_t size() const OVERRIDE;
private:
+ virtual ~RefCountedStaticMemory();
+
const unsigned char* data_;
size_t length_;
@@ -79,7 +81,6 @@ class BASE_EXPORT RefCountedBytes : public RefCountedMemory {
std::vector<unsigned char>& data() { return data_; }
private:
- friend class base::RefCountedThreadSafe<RefCountedBytes>;
virtual ~RefCountedBytes();
std::vector<unsigned char> data_;
@@ -106,7 +107,6 @@ class BASE_EXPORT RefCountedString : public RefCountedMemory {
std::string& data() { return data_; }
private:
- friend class base::RefCountedThreadSafe<RefCountedString>;
virtual ~RefCountedString();
std::string data_;
« no previous file with comments | « base/files/file_path_watcher_stub.cc ('k') | base/memory/ref_counted_memory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698