Simplify benchmark internal API.

Simplify benchmark internal API.

I'm not quite sure why I wrote such a convoluted API with setLoops()/getLoops().
This replaces it with a loops argument passed to onDraw().

This CL is largely mechanical translation from the old API to the new one.
MathBench used this->getLoops() outside onDraw(), which seems incorrect.  I
fixed it.

BUG=

Committed: http://code.google.com/p/skia/source/detail?r=12466

[mtklein, 2013-12-03 00:42:11]

Was just looking at a new benchmark I wrote and realized how silly the API is.

[djsollen, 2013-12-03 15:12:51]

https://codereview.chromium.org/99893003/diff/1/bench/SkBenchmark.h
File bench/SkBenchmark.h (right):

https://codereview.chromium.org/99893003/diff/1/bench/SkBenchmark.h#newcode119
bench/SkBenchmark.h:119: virtual void onDraw(const int loops, SkCanvas*) = 0;
should we make this the second param and have it default to 1?

https://codereview.chromium.org/99893003/diff/1/bench/benchmain.cpp
File bench/benchmain.cpp (right):

https://codereview.chromium.org/99893003/diff/1/bench/benchmain.cpp#newcode519
bench/benchmain.cpp:519: bench->draw(1, recordFrom.beginRecording(dim.fX,
dim.fY, kRecordFlags));
if loops was the second param we could make it default to 1.

[djsollen, 2013-12-03 15:16:23]

lgtm

I have been convinced that making loops non-optional is the way to go.

[commit-bot: I haz the power, 2013-12-03 15:18:05]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/mtklein@google.com/99893003/1

[commit-bot: I haz the power, 2013-12-03 15:18:27]

Failed to apply patch for bench/ColorPrivBench.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file bench/ColorPrivBench.cpp
  Hunk #1 FAILED at 24.
  1 out of 1 hunk FAILED -- saving rejects to file bench/ColorPrivBench.cpp.rej

Patch:       bench/ColorPrivBench.cpp
Index: bench/ColorPrivBench.cpp
diff --git a/bench/ColorPrivBench.cpp b/bench/ColorPrivBench.cpp
index
3143ef45256f321feeb5442cd03f4630840392d9..dd672ac807cdee6b5da98821cf6adb98f2ab8767
100644
--- a/bench/ColorPrivBench.cpp
+++ b/bench/ColorPrivBench.cpp
@@ -24,10 +24,10 @@ public:
 
     virtual const char* onGetName() SK_OVERRIDE { return fName.c_str(); }
 
-    virtual void onDraw(SkCanvas*) SK_OVERRIDE {
+    virtual void onDraw(const int loops, SkCanvas*) SK_OVERRIDE {
         const SkPMColor src = 0xAB998877, dst = 0x66334455;
         volatile SkPMColor junk = 0;
-        for (int i = 0; i < 10*this->getLoops(); ++i) {
+        for (int i = 0; i < 10*loops; ++i) {
             for (size_t j = 0; j <= SK_ARRAY_COUNT(fScales); j++) {
                 const unsigned scale = fScales[j];
                 if (kFast && kScale) {

[commit-bot: I haz the power, 2013-12-03 16:44:20]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/mtklein@google.com/99893003/20001

[commit-bot: I haz the power, 2013-12-03 18:17:32]

Change committed as 12466