Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 996473005: Revert of [Sync] Refactor AttachmentStore classes. Introduce concept of referrer. (Closed)

Created:
5 years, 9 months ago by Bence
Modified:
5 years, 9 months ago
Reviewers:
cjhopman, maniscalco, pavely
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Sync] Refactor AttachmentStore classes. Introduce concept of referrer. (patchset #2 id:20001 of https://codereview.chromium.org/986743004/) Reason for revert: I think this CL is responsible for tree closing compile failure https://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/26672/steps/compile/logs/stdio. Original issue's description: > [Sync] Refactor AttachmentStore classes. Introduce concept of referrer. > > In this change: > - Move towards following class hierarchy: http://www.plantuml.com:80/plantuml/png/ZPBTJiCm38NlynIvv4TzWsaI525nCI5jkw-on1EZQHmvwQG9U7TC4-ZeKiITvNm-EiSExbv1Hxc6VOszYs24mDHQeG6xFNcGRqBAknYLVkd0nKr40l7nmqrU1deDeRUHYrfPkrEw3LmJx848YCkWqODfkECZBIOAZuHin9abWxUo9b0Hdjt38RGJyEhwZ4YZI9kJq_mmRp0pAPKnd7pGgG8t6usTHyVe7_FPtY3mbOth9ghGDjGxTnwlaEq-ySjv-KmCwZflxvVyE5bSIa4Mw7ZGyDHvAyHurPkgkhZgz9PuoNp75tDhAUZcJ68cwkATHyfXnFWn4_PFDsKuNLuKLrFodGS-0G00 > - Remove AttachmenService::GetStore. Now attachment store is owned by > model type, there is no need to get it from AttachmentService > - Introduce AttachmentReferrer. There is no functionality behind it yet > and interface is not complete for it. These will come in the next change. > > BUG=457735 > R=maniscalco@chromium.org > TEST=Not exposed in chrome. Only unit tests available (sync_unit_tests) > > Committed: https://crrev.com/6adcada8a799057c31c0f17550c9e2747a8df847 > Cr-Commit-Position: refs/heads/master@{#319733} TBR=maniscalco@chromium.org,cjhopman@chromium.org,pavely@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=457735 Committed: https://crrev.com/cd8db1dfaf165cbca88f38ecf50a5cacc09959b1 Cr-Commit-Position: refs/heads/master@{#319760}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+623 lines, -744 lines) Patch
M chrome/browser/sync/profile_sync_components_factory_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_mock.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_mock.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/core/dom_distiller_store.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/device_info_data_type_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/fake_generic_change_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/generic_change_processor.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/generic_change_processor.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/sync_driver/generic_change_processor_factory.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M components/sync_driver/generic_change_processor_unittest.cc View 6 chunks +30 lines, -26 lines 0 comments Download
M components/sync_driver/shared_change_processor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/sync_api_component_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/ui_data_type_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/BUILD.gn View 4 chunks +3 lines, -5 lines 0 comments Download
M sync/api/attachments/attachment_store.h View 8 chunks +72 lines, -47 lines 0 comments Download
M sync/api/attachments/attachment_store.cc View 2 chunks +21 lines, -62 lines 0 comments Download
D sync/api/attachments/attachment_store_backend.h View 1 chunk +0 lines, -64 lines 0 comments Download
D sync/api/attachments/attachment_store_backend.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M sync/api/fake_syncable_service.h View 3 chunks +4 lines, -3 lines 0 comments Download
M sync/api/fake_syncable_service.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M sync/api/syncable_service.h View 1 chunk +5 lines, -6 lines 0 comments Download
M sync/api/syncable_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/attachments/attachment_service_impl.cc View 4 chunks +10 lines, -5 lines 0 comments Download
M sync/internal_api/attachments/attachment_service_impl_unittest.cc View 16 chunks +42 lines, -57 lines 0 comments Download
M sync/internal_api/attachments/attachment_service_proxy.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M sync/internal_api/attachments/attachment_service_proxy_unittest.cc View 2 chunks +6 lines, -0 lines 0 comments Download
D sync/internal_api/attachments/attachment_store_frontend.cc View 1 chunk +0 lines, -99 lines 0 comments Download
D sync/internal_api/attachments/attachment_store_frontend_unittest.cc View 1 chunk +0 lines, -215 lines 0 comments Download
A sync/internal_api/attachments/attachment_store_handle.cc View 1 chunk +88 lines, -0 lines 0 comments Download
A sync/internal_api/attachments/attachment_store_handle_unittest.cc View 1 chunk +208 lines, -0 lines 0 comments Download
M sync/internal_api/attachments/attachment_store_test_template.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/attachments/in_memory_attachment_store.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M sync/internal_api/attachments/in_memory_attachment_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/attachments/on_disk_attachment_store.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M sync/internal_api/attachments/on_disk_attachment_store_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M sync/internal_api/public/attachments/attachment_service.h View 1 chunk +5 lines, -0 lines 0 comments Download
M sync/internal_api/public/attachments/attachment_service_impl.h View 4 chunks +3 lines, -5 lines 0 comments Download
M sync/internal_api/public/attachments/attachment_service_proxy.h View 2 chunks +5 lines, -0 lines 0 comments Download
D sync/internal_api/public/attachments/attachment_store_frontend.h View 1 chunk +0 lines, -69 lines 0 comments Download
A sync/internal_api/public/attachments/attachment_store_handle.h View 1 chunk +68 lines, -0 lines 0 comments Download
M sync/internal_api/public/attachments/in_memory_attachment_store.h View 2 chunks +2 lines, -6 lines 0 comments Download
M sync/internal_api/public/attachments/on_disk_attachment_store.h View 2 chunks +2 lines, -6 lines 0 comments Download
M sync/sync.gyp View 3 chunks +2 lines, -4 lines 0 comments Download
M sync/sync_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Bence
Created Revert of [Sync] Refactor AttachmentStore classes. Introduce concept of referrer.
5 years, 9 months ago (2015-03-09 23:08:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/996473005/1
5 years, 9 months ago (2015-03-09 23:10:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 23:13:04 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 23:14:32 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd8db1dfaf165cbca88f38ecf50a5cacc09959b1
Cr-Commit-Position: refs/heads/master@{#319760}

Powered by Google App Engine
This is Rietveld 408576698