Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: sync/internal_api/attachments/attachment_store_handle_unittest.cc

Issue 996473005: Revert of [Sync] Refactor AttachmentStore classes. Introduce concept of referrer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/attachments/attachment_store_handle_unittest.cc
diff --git a/sync/internal_api/attachments/attachment_store_handle_unittest.cc b/sync/internal_api/attachments/attachment_store_handle_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..23c0f09e7a06ecc9a283d7e673835732a132af41
--- /dev/null
+++ b/sync/internal_api/attachments/attachment_store_handle_unittest.cc
@@ -0,0 +1,208 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "sync/internal_api/public/attachments/attachment_store_handle.h"
+
+#include "base/bind.h"
+#include "base/callback.h"
+#include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/message_loop/message_loop.h"
+#include "base/run_loop.h"
+#include "base/thread_task_runner_handle.h"
+#include "sync/api/attachments/attachment.h"
+#include "sync/api/attachments/attachment_id.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace syncer {
+
+namespace {
+
+class MockAttachmentStore : public AttachmentStoreBackend {
+ public:
+ MockAttachmentStore(const base::Closure& init_called,
+ const base::Closure& read_called,
+ const base::Closure& write_called,
+ const base::Closure& drop_called,
+ const base::Closure& read_metadata_called,
+ const base::Closure& read_all_metadata_called,
+ const base::Closure& dtor_called)
+ : AttachmentStoreBackend(nullptr),
+ init_called_(init_called),
+ read_called_(read_called),
+ write_called_(write_called),
+ drop_called_(drop_called),
+ read_metadata_called_(read_metadata_called),
+ read_all_metadata_called_(read_all_metadata_called),
+ dtor_called_(dtor_called) {}
+
+ ~MockAttachmentStore() override { dtor_called_.Run(); }
+
+ void Init(const AttachmentStore::InitCallback& callback) override {
+ init_called_.Run();
+ }
+
+ void Read(const AttachmentIdList& ids,
+ const AttachmentStore::ReadCallback& callback) override {
+ read_called_.Run();
+ }
+
+ void Write(const AttachmentList& attachments,
+ const AttachmentStore::WriteCallback& callback) override {
+ write_called_.Run();
+ }
+
+ void Drop(const AttachmentIdList& ids,
+ const AttachmentStore::DropCallback& callback) override {
+ drop_called_.Run();
+ }
+
+ void ReadMetadata(
+ const AttachmentIdList& ids,
+ const AttachmentStore::ReadMetadataCallback& callback) override {
+ read_metadata_called_.Run();
+ }
+
+ void ReadAllMetadata(
+ const AttachmentStore::ReadMetadataCallback& callback) override {
+ read_all_metadata_called_.Run();
+ }
+
+ base::Closure init_called_;
+ base::Closure read_called_;
+ base::Closure write_called_;
+ base::Closure drop_called_;
+ base::Closure read_metadata_called_;
+ base::Closure read_all_metadata_called_;
+ base::Closure dtor_called_;
+};
+
+} // namespace
+
+class AttachmentStoreHandleTest : public testing::Test {
+ protected:
+ AttachmentStoreHandleTest()
+ : init_call_count_(0),
+ read_call_count_(0),
+ write_call_count_(0),
+ drop_call_count_(0),
+ read_metadata_call_count_(0),
+ read_all_metadata_call_count_(0),
+ dtor_call_count_(0) {}
+
+ void SetUp() override {
+ scoped_ptr<AttachmentStoreBackend> backend(new MockAttachmentStore(
+ base::Bind(&AttachmentStoreHandleTest::InitCalled,
+ base::Unretained(this)),
+ base::Bind(&AttachmentStoreHandleTest::ReadCalled,
+ base::Unretained(this)),
+ base::Bind(&AttachmentStoreHandleTest::WriteCalled,
+ base::Unretained(this)),
+ base::Bind(&AttachmentStoreHandleTest::DropCalled,
+ base::Unretained(this)),
+ base::Bind(&AttachmentStoreHandleTest::ReadMetadataCalled,
+ base::Unretained(this)),
+ base::Bind(&AttachmentStoreHandleTest::ReadAllMetadataCalled,
+ base::Unretained(this)),
+ base::Bind(&AttachmentStoreHandleTest::DtorCalled,
+ base::Unretained(this))));
+ attachment_store_handle_ = new AttachmentStoreHandle(
+ backend.Pass(), base::ThreadTaskRunnerHandle::Get());
+ }
+
+ static void DoneWithResult(const AttachmentStore::Result& result) {
+ NOTREACHED();
+ }
+
+ static void ReadDone(const AttachmentStore::Result& result,
+ scoped_ptr<AttachmentMap> attachments,
+ scoped_ptr<AttachmentIdList> unavailable_attachments) {
+ NOTREACHED();
+ }
+
+ static void ReadMetadataDone(const AttachmentStore::Result& result,
+ scoped_ptr<AttachmentMetadataList> metadata) {
+ NOTREACHED();
+ }
+
+ void InitCalled() { ++init_call_count_; }
+
+ void ReadCalled() { ++read_call_count_; }
+
+ void WriteCalled() { ++write_call_count_; }
+
+ void DropCalled() { ++drop_call_count_; }
+
+ void ReadMetadataCalled() { ++read_metadata_call_count_; }
+
+ void ReadAllMetadataCalled() { ++read_all_metadata_call_count_; }
+
+ void DtorCalled() { ++dtor_call_count_; }
+
+ void RunMessageLoop() {
+ base::RunLoop run_loop;
+ run_loop.RunUntilIdle();
+ }
+
+ base::MessageLoop message_loop_;
+ scoped_refptr<AttachmentStoreHandle> attachment_store_handle_;
+ int init_call_count_;
+ int read_call_count_;
+ int write_call_count_;
+ int drop_call_count_;
+ int read_metadata_call_count_;
+ int read_all_metadata_call_count_;
+ int dtor_call_count_;
+};
+
+// Test that method calls are forwarded to backend loop
+TEST_F(AttachmentStoreHandleTest, MethodsCalled) {
+ AttachmentIdList ids;
+ AttachmentList attachments;
+
+ attachment_store_handle_->Init(
+ base::Bind(&AttachmentStoreHandleTest::DoneWithResult));
+ EXPECT_EQ(init_call_count_, 0);
+ RunMessageLoop();
+ EXPECT_EQ(init_call_count_, 1);
+
+ attachment_store_handle_->Read(
+ ids, base::Bind(&AttachmentStoreHandleTest::ReadDone));
+ EXPECT_EQ(read_call_count_, 0);
+ RunMessageLoop();
+ EXPECT_EQ(read_call_count_, 1);
+
+ attachment_store_handle_->Write(
+ attachments, base::Bind(&AttachmentStoreHandleTest::DoneWithResult));
+ EXPECT_EQ(write_call_count_, 0);
+ RunMessageLoop();
+ EXPECT_EQ(write_call_count_, 1);
+
+ attachment_store_handle_->Drop(
+ ids, base::Bind(&AttachmentStoreHandleTest::DoneWithResult));
+ EXPECT_EQ(drop_call_count_, 0);
+ RunMessageLoop();
+ EXPECT_EQ(drop_call_count_, 1);
+
+ attachment_store_handle_->ReadMetadata(
+ ids, base::Bind(&AttachmentStoreHandleTest::ReadMetadataDone));
+ EXPECT_EQ(read_metadata_call_count_, 0);
+ RunMessageLoop();
+ EXPECT_EQ(read_metadata_call_count_, 1);
+
+ attachment_store_handle_->ReadAllMetadata(
+ base::Bind(&AttachmentStoreHandleTest::ReadMetadataDone));
+ EXPECT_EQ(read_all_metadata_call_count_, 0);
+ RunMessageLoop();
+ EXPECT_EQ(read_all_metadata_call_count_, 1);
+
+ // Releasing referehce to AttachmentStoreHandle should result in
+ // MockAttachmentStore being deleted on backend loop.
+ attachment_store_handle_ = NULL;
+ EXPECT_EQ(dtor_call_count_, 0);
+ RunMessageLoop();
+ EXPECT_EQ(dtor_call_count_, 1);
+}
+
+} // namespace syncer

Powered by Google App Engine
This is Rietveld 408576698