components/sync_driver/sync_api_component_factory.h - Issue 996473005: Revert of [Sync] Refactor AttachmentStore classes. Introduce concept of referrer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/sync_api_component_factory.h

Issue 996473005: Revert of [Sync] Refactor AttachmentStore classes. Introduce concept of referrer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync_driver/shared_change_processor_unittest.cc ('k') | components/sync_driver/ui_data_type_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_driver/sync_api_component_factory.h

diff --git a/components/sync_driver/sync_api_component_factory.h b/components/sync_driver/sync_api_component_factory.h

index 7ba8200193d4db490bfa09586417a235074ab4a4..429ac9909849b53c72673b62f611d9b3634d12f4 100644

--- a/components/sync_driver/sync_api_component_factory.h

+++ b/components/sync_driver/sync_api_component_factory.h

@@ -37,7 +37,7 @@

// provided. AttachmentService doesn't take ownership of delegate, the pointer

// must be valid throughout AttachmentService lifetime.

virtual scoped_ptr<syncer::AttachmentService> CreateAttachmentService(

- scoped_ptr<syncer::AttachmentStore> attachment_store,

+ const scoped_refptr<syncer::AttachmentStore>& attachment_store,

const syncer::UserShare& user_share,

const std::string& store_birthday,

syncer::ModelType model_type,