chrome/browser/sync/profile_sync_components_factory_impl.cc - Issue 996473005: Revert of [Sync] Refactor AttachmentStore classes. Introduce concept of referrer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_components_factory_impl.cc

Issue 996473005: Revert of [Sync] Refactor AttachmentStore classes. Introduce concept of referrer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/profile_sync_components_factory_impl.h ('k') | chrome/browser/sync/profile_sync_components_factory_mock.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_components_factory_impl.cc

diff --git a/chrome/browser/sync/profile_sync_components_factory_impl.cc b/chrome/browser/sync/profile_sync_components_factory_impl.cc

index 6f078f16dc22eb0768037d2a8dc7bde4132c363f..c71e48549377517dcd3384e54bf90d348db93b6d 100644

--- a/chrome/browser/sync/profile_sync_components_factory_impl.cc

+++ b/chrome/browser/sync/profile_sync_components_factory_impl.cc

@@ -640,7 +640,7 @@

scoped_ptr<syncer::AttachmentService>

ProfileSyncComponentsFactoryImpl::CreateAttachmentService(

- scoped_ptr<syncer::AttachmentStore> attachment_store,

+ const scoped_refptr<syncer::AttachmentStore>& attachment_store,

const syncer::UserShare& user_share,

const std::string& store_birthday,

syncer::ModelType model_type,

@@ -685,10 +685,12 @@

base::TimeDelta::FromMinutes(30);

const base::TimeDelta max_backoff_delay = base::TimeDelta::FromHours(4);

scoped_ptr<syncer::AttachmentService> attachment_service(

- new syncer::AttachmentServiceImpl(

- attachment_store.Pass(), attachment_uploader.Pass(),

- attachment_downloader.Pass(), delegate, initial_backoff_delay,

- max_backoff_delay));

+ new syncer::AttachmentServiceImpl(attachment_store,

+ attachment_uploader.Pass(),

+ attachment_downloader.Pass(),

+ delegate,

+ initial_backoff_delay,

+ max_backoff_delay));

return attachment_service.Pass();

}