Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: sync/api/syncable_service.h

Issue 996473005: Revert of [Sync] Refactor AttachmentStore classes. Introduce concept of referrer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/api/fake_syncable_service.cc ('k') | sync/api/syncable_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/api/syncable_service.h
diff --git a/sync/api/syncable_service.h b/sync/api/syncable_service.h
index 0d5aae4c5b534a1b9244e755b681c712274fd94b..f83a017c2da14f1fa08f96b4bcdcc9b760d1c876 100644
--- a/sync/api/syncable_service.h
+++ b/sync/api/syncable_service.h
@@ -66,16 +66,15 @@
SyncError ProcessSyncChanges(const tracked_objects::Location& from_here,
const SyncChangeList& change_list) override = 0;
- // Returns AttachmentStore for use by sync when uploading or downloading
- // attachments.
+ // Returns AttachmentStore used by datatype. Attachment store is used by sync
+ // when uploading or downloading attachments.
// GetAttachmentStore is called right before MergeDataAndStartSyncing. If at
// that time GetAttachmentStore returns NULL then datatype is considered not
// using attachments and all attempts to upload/download attachments will
// fail. Default implementation returns NULL. Datatype that uses sync
- // attachments should create attachment store, implement GetAttachmentStore
- // to return result of AttachmentStore::CreateAttachmentStoreForSync() from
- // attachment store object.
- virtual scoped_ptr<AttachmentStore> GetAttachmentStoreForSync();
+ // attachemnts should create attachment store and implement GetAttachmentStore
+ // to return pointer to it.
+ virtual scoped_refptr<AttachmentStore> GetAttachmentStore();
// Called by sync to provide AttachmentService to be used to download
// attachments.
« no previous file with comments | « sync/api/fake_syncable_service.cc ('k') | sync/api/syncable_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698