Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 991863003: Avoid unnecessary copies of AccessibilityChildrenVector (Closed)

Created:
5 years, 9 months ago by k.czech
Modified:
5 years, 9 months ago
Reviewers:
dmazzoni
CC:
blink-reviews, nektarios, dmazzoni, je_julie(Not used), aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Avoid unnecessary copies of AccessibilityChildrenVector Keep children as a const reference to AccessibilityChildrenVector BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191571

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -16 lines) Patch
M Source/modules/accessibility/AXARIAGrid.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXARIAGridCell.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/accessibility/AXARIAGridRow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXLayoutObject.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXObjectCacheImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXTable.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/modules/accessibility/AXTableColumn.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXTableRow.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
k.czech
5 years, 9 months ago (2015-03-09 15:41:19 UTC) #2
dmazzoni
lgtm
5 years, 9 months ago (2015-03-09 16:36:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/991863003/1
5 years, 9 months ago (2015-03-09 16:36:27 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 18:10:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191571

Powered by Google App Engine
This is Rietveld 408576698