Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: Source/modules/accessibility/AXARIAGridRow.cpp

Issue 991863003: Avoid unnecessary copies of AccessibilityChildrenVector (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 { 53 {
54 AXObject* parent = parentTable(); 54 AXObject* parent = parentTable();
55 if (!parent) 55 if (!parent)
56 return false; 56 return false;
57 57
58 return parent->ariaRoleAttribute() == TreeGridRole; 58 return parent->ariaRoleAttribute() == TreeGridRole;
59 } 59 }
60 60
61 void AXARIAGridRow::headerObjectsForRow(AccessibilityChildrenVector& headers) 61 void AXARIAGridRow::headerObjectsForRow(AccessibilityChildrenVector& headers)
62 { 62 {
63 AccessibilityChildrenVector rowChildren = children(); 63 const AccessibilityChildrenVector& rowChildren = children();
64 unsigned childrenCount = rowChildren.size(); 64 unsigned childrenCount = rowChildren.size();
65 for (unsigned i = 0; i < childrenCount; i++) { 65 for (unsigned i = 0; i < childrenCount; i++) {
66 AXObject* cell = rowChildren[i].get(); 66 AXObject* cell = rowChildren[i].get();
67 if (cell->roleValue() == RowHeaderRole) 67 if (cell->roleValue() == RowHeaderRole)
68 headers.append(cell); 68 headers.append(cell);
69 } 69 }
70 } 70 }
71 71
72 } // namespace blink 72 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/accessibility/AXARIAGridCell.cpp ('k') | Source/modules/accessibility/AXLayoutObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698