Source/modules/accessibility/AXARIAGridRow.cpp - Issue 991863003: Avoid unnecessary copies of AccessibilityChildrenVector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXARIAGridRow.cpp

Issue 991863003: Avoid unnecessary copies of AccessibilityChildrenVector (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/accessibility/AXARIAGridRow.cpp

diff --git a/Source/modules/accessibility/AXARIAGridRow.cpp b/Source/modules/accessibility/AXARIAGridRow.cpp

index 2f66a4b118cece3487d3216d505838b2cd105a21..90917345a409b4e7562c52cc19b12932fd9eff52 100644

--- a/Source/modules/accessibility/AXARIAGridRow.cpp

+++ b/Source/modules/accessibility/AXARIAGridRow.cpp

@@ -60,7 +60,7 @@ bool AXARIAGridRow::isARIATreeGridRow() const

void AXARIAGridRow::headerObjectsForRow(AccessibilityChildrenVector& headers)

{

- AccessibilityChildrenVector rowChildren = children();

+ const AccessibilityChildrenVector& rowChildren = children();

unsigned childrenCount = rowChildren.size();

for (unsigned i = 0; i < childrenCount; i++) {

AXObject* cell = rowChildren[i].get();

« no previous file with comments | « Source/modules/accessibility/AXARIAGridCell.cpp ('k') | Source/modules/accessibility/AXLayoutObject.cpp » ('j') | no next file with comments »