Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1120)

Unified Diff: Source/modules/accessibility/AXARIAGridCell.cpp

Issue 991863003: Avoid unnecessary copies of AccessibilityChildrenVector (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/accessibility/AXARIAGrid.cpp ('k') | Source/modules/accessibility/AXARIAGridRow.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXARIAGridCell.cpp
diff --git a/Source/modules/accessibility/AXARIAGridCell.cpp b/Source/modules/accessibility/AXARIAGridCell.cpp
index 8bb16c403d5bbaecf8d45a4d386f87899aaf0c7b..907e653b03ca6974697db6ca1e350ac540e15bcf 100644
--- a/Source/modules/accessibility/AXARIAGridCell.cpp
+++ b/Source/modules/accessibility/AXARIAGridCell.cpp
@@ -97,7 +97,7 @@ void AXARIAGridCell::rowIndexRange(pair<unsigned, unsigned>& rowRange)
if (!columnCount)
return;
- AccessibilityChildrenVector siblings = parent->children();
+ const AccessibilityChildrenVector& siblings = parent->children();
unsigned childrenSize = siblings.size();
for (unsigned k = 0; k < childrenSize; ++k) {
if (siblings[k].get() == this) {
@@ -120,7 +120,7 @@ void AXARIAGridCell::columnIndexRange(pair<unsigned, unsigned>& columnRange)
if (!parent->isTableRow() && !parent->isAXTable())
return;
- AccessibilityChildrenVector siblings = parent->children();
+ const AccessibilityChildrenVector& siblings = parent->children();
unsigned childrenSize = siblings.size();
for (unsigned k = 0; k < childrenSize; ++k) {
if (siblings[k].get() == this) {
« no previous file with comments | « Source/modules/accessibility/AXARIAGrid.cpp ('k') | Source/modules/accessibility/AXARIAGridRow.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698